mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: Zachary Amsden <zach@vmware.com>
Cc: Andi Kleen <ak@suse.de>,
	virtualization@lists.osdl.org, Andrew Morton <akpm@osdl.org>,
	Xen-devel <xen-devel@lists.xensource.com>,
	Jeremy Fitzhardinge <jeremy@xensource.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Chris Wright <chrisw@sous-sol.org>,
	Ian Pratt <ian.pratt@xensource.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Christoph Lameter <clameter@sgi.com>
Subject: Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here
Date: Wed, 2 Aug 2006 00:13:06 -0700	[thread overview]
Message-ID: <20060802071306.GN2654@sequoia.sous-sol.org> (raw)
In-Reply-To: <44D04577.9000904@vmware.com>

* Zachary Amsden (zach@vmware.com) wrote:
> Andi Kleen wrote:
> >nst char *arch_vma_name(struct vm_area_struct *vma);
> >  
> >> 
> >>+#ifndef pgd_free_mm
> >>+#define pgd_free_mm(mm) pgd_free((mm)->pgd)
> >>+#endif
> >>    
> >
> >Sorry, but these ifdefs are too ugly. I would prefer if you 
> >just updated all architectures, even though it will make the patch
> >somewhat bigger
> >  
> I'm fine with doing that, and yes this is ugly.  Will take awhile though 
> - for efficiency of mercurial patch tools, I deprecated all 
> architectures but i386, x86_64, and um from my local tree.  <Slaps head>.

While you're at it, can you please make sure there's some nice changelog
comments.  The current one only has diffstat.

thanks,
-chris

      reply	other threads:[~2006-08-02  7:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8235caea9d688b78ce4b.1154462450@ezr>
2006-08-02  3:14 ` Andi Kleen
2006-08-02  6:25   ` [Xen-devel] " Zachary Amsden
2006-08-02  7:13     ` Chris Wright [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802071306.GN2654@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=ebiederm@xmission.com \
    --cc=ian.pratt@xensource.com \
    --cc=jeremy@xensource.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.osdl.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=zach@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome