From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Andrew Victor <andrew@sanpeople.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] at91_serial: Fix break handling
Date: Wed, 2 Aug 2006 16:17:41 +0100 [thread overview]
Message-ID: <20060802151741.GB32102@flint.arm.linux.org.uk> (raw)
In-Reply-To: <11545303083943-git-send-email-hskinnemoen@atmel.com>
On Wed, Aug 02, 2006 at 04:51:47PM +0200, Haavard Skinnemoen wrote:
> @@ -269,9 +271,14 @@ static void at91_rx_chars(struct uart_po
> UART_PUT_CR(port, AT91_US_RSTSTA); /* clear error */
> if (status & AT91_US_RXBRK) {
> status &= ~(AT91_US_PARE | AT91_US_FRAME); /* ignore side-effect */
> - port->icount.brk++;
> - if (uart_handle_break(port))
> + if (at91_port->break_active) {
> + at91_port->break_active = 0;
> + } else {
> + at91_port->break_active = 1;
> + port->icount.brk++;
> + uart_handle_break(port);
> goto ignore_char;
> + }
Two points here.
1. Effectively, this just ignores every second break status. We've no idea
_which_ break interrupt is going to be ignored.
2. it breaks break handling. uart_handle_break returns a value for a
reason. Use it - don't unconditionally ignore the received character.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-08-02 15:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 14:51 [PATCH 0/3] at91_serial: Introduction Haavard Skinnemoen
2006-08-02 14:51 ` [PATCH 1/3] at91_serial: support AVR32 Haavard Skinnemoen
2006-08-02 14:51 ` [PATCH 2/3] at91_serial: Fix break handling Haavard Skinnemoen
2006-08-02 14:51 ` [PATCH 3/3] at91_serial: Fix roundoff error in at91_console_get_options Haavard Skinnemoen
2006-08-02 15:17 ` Russell King [this message]
2006-08-02 16:14 ` [PATCH 2/3] at91_serial: Fix break handling Haavard Skinnemoen
2006-08-02 16:21 ` Russell King
2006-08-02 17:39 ` Haavard Skinnemoen
2006-08-02 15:15 ` [PATCH 1/3] at91_serial: support AVR32 Russell King
2006-08-02 16:00 ` Haavard Skinnemoen
2006-08-02 16:03 ` Russell King
2006-08-02 17:27 ` Haavard Skinnemoen
2006-09-23 21:14 ` [PATCH 0/3] at91_serial: Introduction Russell King
2006-09-25 12:01 ` Haavard Skinnemoen
2006-09-25 12:16 ` Russell King
2006-09-26 9:06 ` Andrew Victor
2006-09-26 9:27 ` Haavard Skinnemoen
2006-09-26 9:28 ` Andrew Victor
2006-09-26 9:48 ` Haavard Skinnemoen
2006-09-26 16:03 ` Andrew Victor
2006-09-27 13:31 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802151741.GB32102@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=andrew@sanpeople.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome