From: Andrew Morton <akpm@osdl.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
Armin Schindler <mac@melware.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] eicon: fix define conflict with ptrace
Date: Thu, 3 Aug 2006 13:59:00 -0700 [thread overview]
Message-ID: <20060803135900.0fc41ac5.akpm@osdl.org> (raw)
In-Reply-To: <1154639399.23655.129.camel@localhost.localdomain>
On Thu, 03 Aug 2006 22:09:59 +0100
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Ar Gwe, 2006-08-04 am 00:34 +0400, ysgrifennodd Alexey Dobriyan:
> > * MODE_MASK is unused in eicon driver.
> > * Conflicts with a ptrace stuff on arm.
> >
> > drivers/isdn/hardware/eicon/divasync.h:259:1: warning: "MODE_MASK" redefined
> > include2/asm/ptrace.h:48:1: warning: this is the location of the previous definition
> >
> > Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>
> NAK. You need to fix all the code expecting to use the MODE_MASK with a
> value of 0x00000080
There isn't any (under drivers/isdn, anyway).
I assume Alexey already checked that, but forgot to tell us.
Alexey, your changelogging often tends to be too terse.
next prev parent reply other threads:[~2006-08-03 20:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 20:34 Alexey Dobriyan
2006-08-03 21:09 ` Alan Cox
2006-08-03 20:59 ` Andrew Morton [this message]
2006-08-03 21:16 ` Alexey Dobriyan
2006-08-04 14:36 ` Armin Schindler
2006-08-04 14:40 ` Armin Schindler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060803135900.0fc41ac5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=adobriyan@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mac@melware.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome