From: Karsten Keil <kkeil@suse.de>
To: Jukka Partanen <jspartanen@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.4.32] Fix AVM C4 ISDN card init problems with newer CPUs
Date: Thu, 3 Aug 2006 19:31:04 +0200 [thread overview]
Message-ID: <20060803173104.GA22317@pingi.kke.suse.de> (raw)
In-Reply-To: <d50597c30608030953l41e8661dg1c10faeac31cc87f@mail.gmail.com>
Yes, that should be go in.
AVM C4 ISDN NIC: Add three memory barriers, taken from 2.6.7,
(they are there in 2.6.17.7 too), to fix module initialization
problems appearing with at least some newer Celerons and
Pentium III.
Acked-by: Karsten Keil <kkeil@suse.de>
Signed-off-by: Jukka Partanen <jspartanen@gmail.com>
--- drivers/isdn/avmb1/c4.c.orig 2006-08-03 19:32:17.000000000 +0000
+++ drivers/isdn/avmb1/c4.c 2006-08-03 19:32:55.000000000 +0000
@@ -151,6 +151,7 @@
while (c4inmeml(card->mbase+DOORBELL) != 0xffffffff) {
if (!time_before(jiffies, stop))
return -1;
+ mb();
}
return 0;
}
@@ -305,6 +306,7 @@
if (!time_before(jiffies, stop))
return;
c4outmeml(card->mbase+DOORBELL, DBELL_ADDR);
+ mb();
}
c4_poke(card, DC21285_ARMCSR_BASE + CHAN_1_CONTROL, 0);
@@ -328,6 +330,7 @@
if (!time_before(jiffies, stop))
return 2;
c4outmeml(card->mbase+DOORBELL, DBELL_ADDR);
+ mb();
}
c4_poke(card, DC21285_ARMCSR_BASE + CHAN_1_CONTROL, 0);
--
Karsten Keil
SuSE Labs
ISDN development
next prev parent reply other threads:[~2006-08-03 17:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 16:53 Jukka Partanen
2006-08-03 17:31 ` Karsten Keil [this message]
2006-08-04 10:00 ` Alan Cox
2006-08-03 17:56 ` Alan Cox
2006-08-04 5:08 ` Willy Tarreau
2006-08-04 6:56 ` Willy Tarreau
2006-08-04 10:39 ` Michael Buesch
2006-08-04 12:21 ` Willy Tarreau
2006-08-04 20:14 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060803173104.GA22317@pingi.kke.suse.de \
--to=kkeil@suse.de \
--cc=jspartanen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome