From: Andi Kleen <ak@suse.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix dubious segment register clear in cpu_init()
Date: Fri, 4 Aug 2006 02:23:49 +0200 [thread overview]
Message-ID: <200608040223.49836.ak@suse.de> (raw)
In-Reply-To: <44D28B6F.5030701@goop.org>
On Friday 04 August 2006 01:49, Jeremy Fitzhardinge wrote:
> Fix a very dubious piece of code in
> arch/i386/kernel/cpu/common.c:cpu_init(). This clears out %fs and
> %gs, but clobbers %eax in the process without telling gcc. It turns
> out that gcc happens to be not using %eax at that point anyway so it
> doesn't matter much, but it looks like a bomb waiting to go off.
>
> This does end up saving an instruction, because gcc wants %eax==0 for
> the set_debugreg()s below.
Added thanks
-Andi
prev parent reply other threads:[~2006-08-04 0:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-03 23:49 Jeremy Fitzhardinge
2006-08-04 0:23 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608040223.49836.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome