Re: 2.6.18-rc3-git3 - XFS - BUG: unable to handle kernel NULL pointer dereference at virtual address 00000078

[Nathan Scott <nathans@sgi.com>]

On Fri, Aug 04, 2006 at 10:22:21AM +0200, Jesper Juhl wrote:
> I just hit a BUG that looks XFS related.
> 
> The machine is running 2.6.18-rc3-git3
> 
> (more info below the BUG messages)
> 

Thanks for reporting, Jesper - is it reproducible?  Could you try this
patch for me?  We had a couple of other reports of this, but the earlier
reporters have vanished ... could you let me know if this helps?

cheers.

-- 
Nathan

--- fs/xfs/xfs_alloc.c.orig	2006-08-04 20:00:34.333456250 +1000
+++ fs/xfs/xfs_alloc.c	2006-08-04 20:00:50.586472000 +1000
@@ -1949,14 +1949,8 @@ xfs_alloc_fix_freelist(
 		 * the restrictions correctly.  Can happen for free calls
 		 * on a completely full ag.
 		 */
-		if (targs.agbno == NULLAGBLOCK) {
-			if (!(flags & XFS_ALLOC_FLAG_FREEING)) {
-				xfs_trans_brelse(tp, agflbp);
-				args->agbp = NULL;
-				return 0;
-			}
+		if (targs.agbno == NULLAGBLOCK)
 			break;
-		}
 		/*
 		 * Put each allocated block on the list.
 		 */