mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
To: david-b@pacbell.net
Cc: ab@mycable.de, mgreer@mvista.com, a.zummo@towertech.it,
	linux-kernel@vger.kernel.org
Subject: Re: RTC: add RTC class interface to m41t00 driver
Date: Mon, 07 Aug 2006 02:09:19 +0900 (JST)	[thread overview]
Message-ID: <20060807.020919.15248103.anemo@mba.ocn.ne.jp> (raw)
In-Reply-To: <200608051213.50308.david-b@pacbell.net>

On Sat, 5 Aug 2006 12:13:49 -0700, David Brownell <david-b@pacbell.net> wrote:
> > 1. The driver contains ds_1340 (or st m41t00) definition, but it seems
> >    no way to select the ds_type.
> 
> Which is harmless, since the driver has no code that really needs to care.
> As I said, it's a least-common-denominator driver ... used in my case
> with a SOC that integrates a highly functional (primary) RTC, because
> only the external RTC provides its own battery-backed power domain.

Oh, I missed that point.  It should work for m41t00 indeed.

> This is a limitation of the I2C stack ... one that I observe is being
> worked around by m41t00.c platform_device tricks.  A side effect of those
> tricks is to prevent hooking up more than one of this type I2C chip
> to a system ... not pretty (especially given that it's not documented),
> but often OK.

Yes, some more works would be needed on m41t00 to support multiple
(different) M41Txx chips at same time.

> It would have made more sense to me to have the M41T81 and M41T85 be
> in a different driver, because of the incompatible register layout.
> That's the more traditional approach.

Now I'm thinking this way.  Still thinking...

> My approach was to go for "least common denominator", not "super generic".
> Also, I avoided trying to work around I2C stack issues like the omission
> of per-board tables/customization.  When I2C eventually has a nice clean
> solution for those issues, I expect that will mean adopting the better
> solution involves fewer changes.

OK, I see.  I think LCD approach is worth indeed.

> But I was mostly pointing out that if the goal was to support the m41t00
> RTC (the normal reading of $SUBJECT), that work has been done for some
> time and has already been pushed upstream.

My real target is M41T80, which seems a subset of M41T81.
(Sorry for not writing this before.)

I agree m41t00 can be supported by rtc-ds1307 driver already.

So the next theme would be how we support M41T8x chips.  I think
Alexander's rtc-m41txx is good candidate for them.

Then M41T00 users can choose rtc-ds1307 or rtc-m41t00.  Not so bad, I
think.

---
Atsushi Nemoto

  reply	other threads:[~2006-08-06 17:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-05  2:33 David Brownell
2006-08-05 16:29 ` Atsushi Nemoto
2006-08-05 17:43   ` Alexander Bigga
2006-08-05 20:23     ` David Brownell
2006-08-07 15:01       ` Alexander Bigga
2006-08-05 19:13   ` David Brownell
2006-08-06 17:09     ` Atsushi Nemoto [this message]
2006-08-07 14:55       ` Alexander Bigga
  -- strict thread matches above, loose matches on Subject: below --
2006-08-03 15:21 Atsushi Nemoto
2006-08-03 15:42 ` Atsushi Nemoto
2006-08-04  0:21   ` Mark A. Greer
2006-08-04 14:01     ` Alexander Bigga
2006-08-04 16:03       ` Atsushi Nemoto
2006-08-04 22:57       ` Andrew Morton
2006-08-05 13:28         ` Atsushi Nemoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060807.020919.15248103.anemo@mba.ocn.ne.jp \
    --to=anemo@mba.ocn.ne.jp \
    --cc=a.zummo@towertech.it \
    --cc=ab@mycable.de \
    --cc=david-b@pacbell.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgreer@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®