From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Andi Kleen <ak@suse.de>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
torvalds <torvalds@osdl.org>
Subject: Re: [PATCH 0/9] Replace some ARCH_HAS_XYZZY
Date: Mon, 7 Aug 2006 20:08:04 -0700 [thread overview]
Message-ID: <20060807200804.7847e6d0.rdunlap@xenotime.net> (raw)
In-Reply-To: <200608080405.11111.ak@suse.de>
On Tue, 8 Aug 2006 04:05:11 +0200 Andi Kleen wrote:
> On Monday 07 August 2006 23:13, Randy.Dunlap wrote:
> > On Mon, 3 Jul 2006 10:13:12 -0700 (PDT) Linus Torvalds wrote:
> >
> > [snip]
> >
> > > The whole "ARCH_HAS_XYZZY" is nothing but crap. It's totally unreadable,
> > ...
> > > WE SHOULD GET RID OF ARCH_HAS_XYZZY. It's a disease.
> >
> > Using Kconfig symbols for some of them seems more appropriate to me,
>
> IMHO that's no better.
>
> Instead one should add dummy inlines/macros or asm-generic dummy inlines/macros
> to all the architectures.
They are config characteristics (in many cases). Hiding them in
header files with dummy inlines or with ARCH_HAS_XYZZY is still
hiding them IMO, although the inlines are better than the
ARCH_HAS_XYZZY method. I prefer to see them in the config space
since I think that's where they belong.
---
~Randy
next prev parent reply other threads:[~2006-08-08 3:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 21:13 Randy.Dunlap
2006-08-08 2:05 ` Andi Kleen
2006-08-08 3:08 ` Randy.Dunlap [this message]
2006-08-08 3:15 ` Andi Kleen
2006-08-08 4:27 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807200804.7847e6d0.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®