mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Meelis Roos <mroos@linux.ee>
Cc: nathans@sgi.com, linux-kernel@vger.kernel.org
Subject: Re: XFS warning in 2.6.18-rc4
Date: Thu, 10 Aug 2006 03:06:00 +0400	[thread overview]
Message-ID: <20060809230559.GA7679@martell.zuzino.mipt.ru> (raw)
In-Reply-To: <Pine.SOC.4.61.0608092303570.27011@math.ut.ee>

On Wed, Aug 09, 2006 at 11:04:53PM +0300, Meelis Roos wrote:
> fs/xfs/xfs_bmap.c: In function 'xfs_bmapi':
> fs/xfs/xfs_bmap.c:2662: warning: 'rtx' is used uninitialized in this function

gcc bug again? Corresponding preprocessed source when XFS realtime allocator
is off:

static int xfs_bmap_rtalloc(xfs_bmalloca_t *ap)
{
		...
	xfs_rtblock_t rtx;

		...
	if (ap->eof && ap->off == 0) {
===>		error = (251);		<===
		if (error)
			return error;
		ap->rval = rtx * mp->m_sb.sb_rextsize;
	} else {
		ap->rval = 0;
	}

This is the only place where rtx is "used".

When realtime allocator is on, xfs_rtpick_extent() is real function
either a) returning error and leaving garbage in "rtx", or b)
initializing "rtx" and returning 0.


      parent reply	other threads:[~2006-08-09 23:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-09 20:04 Meelis Roos
2006-08-09 22:56 ` Nathan Scott
2006-08-10 23:47   ` Jesper Juhl
2006-08-10 23:52     ` Nathan Scott
2006-08-11  0:02       ` Jesper Juhl
2006-08-15  3:46       ` David Chinner
2006-08-09 23:06 ` Alexey Dobriyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060809230559.GA7679@martell.zuzino.mipt.ru \
    --to=adobriyan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=nathans@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®