From: Dmitry Torokhov <dtor@insightbb.com>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [patch 4/6] Remove "owner" from backlight_properties structure
Date: Fri, 11 Aug 2006 01:03:14 -0400 [thread overview]
Message-ID: <20060811050611.409915104.dtor@insightbb.com> (raw)
In-Reply-To: <20060811050310.958962036.dtor@insightbb.com>
[-- Attachment #1: backlight-remove-owner.patch --]
[-- Type: text/plain, Size: 6741 bytes --]
Backlight: remove "owner" from backlight_properties structure
Nothing uses it and it is unlikely that it will ever be used -
backlight uses other means to ensure that nothing references
unloaded code.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/macintosh/via-pmu-backlight.c | 1 -
drivers/usb/misc/appledisplay.c | 1 -
drivers/video/aty/aty128fb.c | 1 -
drivers/video/aty/atyfb_base.c | 1 -
drivers/video/aty/radeon_backlight.c | 1 -
drivers/video/backlight/corgi_bl.c | 1 -
drivers/video/backlight/hp680_bl.c | 1 -
drivers/video/backlight/locomolcd.c | 1 -
drivers/video/nvidia/nv_backlight.c | 1 -
drivers/video/riva/fbdev.c | 1 -
include/linux/backlight.h | 3 ---
include/linux/lcd.h | 2 --
12 files changed, 15 deletions(-)
Index: work/drivers/macintosh/via-pmu-backlight.c
===================================================================
--- work.orig/drivers/macintosh/via-pmu-backlight.c
+++ work/drivers/macintosh/via-pmu-backlight.c
@@ -81,7 +81,6 @@ static int pmu_backlight_get_brightness(
}
static struct backlight_properties pmu_backlight_data = {
- .owner = THIS_MODULE,
.get_brightness = pmu_backlight_get_brightness,
.update_status = pmu_backlight_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/drivers/usb/misc/appledisplay.c
===================================================================
--- work.orig/drivers/usb/misc/appledisplay.c
+++ work/drivers/usb/misc/appledisplay.c
@@ -179,7 +179,6 @@ static int appledisplay_bl_get_brightnes
}
static struct backlight_properties appledisplay_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = appledisplay_bl_get_brightness,
.update_status = appledisplay_bl_update_status,
.max_brightness = 0xFF
Index: work/drivers/video/aty/aty128fb.c
===================================================================
--- work.orig/drivers/video/aty/aty128fb.c
+++ work/drivers/video/aty/aty128fb.c
@@ -1792,7 +1792,6 @@ static int aty128_bl_get_brightness(stru
}
static struct backlight_properties aty128_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = aty128_bl_get_brightness,
.update_status = aty128_bl_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/drivers/video/aty/atyfb_base.c
===================================================================
--- work.orig/drivers/video/aty/atyfb_base.c
+++ work/drivers/video/aty/atyfb_base.c
@@ -2191,7 +2191,6 @@ static int aty_bl_get_brightness(struct
}
static struct backlight_properties aty_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = aty_bl_get_brightness,
.update_status = aty_bl_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/drivers/video/aty/radeon_backlight.c
===================================================================
--- work.orig/drivers/video/aty/radeon_backlight.c
+++ work/drivers/video/aty/radeon_backlight.c
@@ -134,7 +134,6 @@ static int radeon_bl_get_brightness(stru
}
static struct backlight_properties radeon_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = radeon_bl_get_brightness,
.update_status = radeon_bl_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/drivers/video/backlight/corgi_bl.c
===================================================================
--- work.orig/drivers/video/backlight/corgi_bl.c
+++ work/drivers/video/backlight/corgi_bl.c
@@ -106,7 +106,6 @@ EXPORT_SYMBOL(corgibl_limit_intensity);
static struct backlight_properties corgibl_data = {
- .owner = THIS_MODULE,
.get_brightness = corgibl_get_intensity,
.update_status = corgibl_set_intensity,
};
Index: work/drivers/video/backlight/hp680_bl.c
===================================================================
--- work.orig/drivers/video/backlight/hp680_bl.c
+++ work/drivers/video/backlight/hp680_bl.c
@@ -96,7 +96,6 @@ static int hp680bl_get_intensity(struct
}
static struct backlight_properties hp680bl_data = {
- .owner = THIS_MODULE,
.max_brightness = HP680_MAX_INTENSITY,
.get_brightness = hp680bl_get_intensity,
.update_status = hp680bl_set_intensity,
Index: work/drivers/video/backlight/locomolcd.c
===================================================================
--- work.orig/drivers/video/backlight/locomolcd.c
+++ work/drivers/video/backlight/locomolcd.c
@@ -142,7 +142,6 @@ static int locomolcd_get_intensity(struc
}
static struct backlight_properties locomobl_data = {
- .owner = THIS_MODULE,
.get_brightness = locomolcd_get_intensity,
.update_status = locomolcd_set_intensity,
.max_brightness = 4,
Index: work/drivers/video/nvidia/nv_backlight.c
===================================================================
--- work.orig/drivers/video/nvidia/nv_backlight.c
+++ work/drivers/video/nvidia/nv_backlight.c
@@ -104,7 +104,6 @@ static int nvidia_bl_get_brightness(stru
}
static struct backlight_properties nvidia_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = nvidia_bl_get_brightness,
.update_status = nvidia_bl_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/drivers/video/riva/fbdev.c
===================================================================
--- work.orig/drivers/video/riva/fbdev.c
+++ work/drivers/video/riva/fbdev.c
@@ -346,7 +346,6 @@ static int riva_bl_get_brightness(struct
}
static struct backlight_properties riva_bl_data = {
- .owner = THIS_MODULE,
.get_brightness = riva_bl_get_brightness,
.update_status = riva_bl_update_status,
.max_brightness = (FB_BACKLIGHT_LEVELS - 1),
Index: work/include/linux/backlight.h
===================================================================
--- work.orig/include/linux/backlight.h
+++ work/include/linux/backlight.h
@@ -17,9 +17,6 @@ struct fb_info;
/* This structure defines all the properties of a backlight
(usually attached to a LCD). */
struct backlight_properties {
- /* Owner module */
- struct module *owner;
-
/* Notify the backlight driver some property has changed */
int (*update_status)(struct backlight_device *);
/* Return the current backlight brightness (accounting for power,
Index: work/include/linux/lcd.h
===================================================================
--- work.orig/include/linux/lcd.h
+++ work/include/linux/lcd.h
@@ -16,8 +16,6 @@ struct fb_info;
/* This structure defines all the properties of a LCD flat panel. */
struct lcd_properties {
- /* Owner module */
- struct module *owner;
/* Get the LCD panel power status (0: full on, 1..3: controller
power on, flat panel power off, 4: full off), see FB_BLANK_XXX */
int (*get_power)(struct lcd_device *);
next prev parent reply other threads:[~2006-08-11 5:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 5:03 [patch 0/6] Backlight & lcd fixes/cleanups Dmitry Torokhov
2006-08-11 5:03 ` [patch 1/6] Convert to use default class device attributes Dmitry Torokhov
2006-08-11 5:03 ` [patch 2/6] Fix error handling when registering new device Dmitry Torokhov
2006-08-11 5:03 ` [patch 3/6] Get rid of excessive amount of likely()s Dmitry Torokhov
2006-08-11 5:03 ` Dmitry Torokhov [this message]
2006-08-11 5:03 ` [patch 5/6] Convert to use mutexes instead of semaphores Dmitry Torokhov
2006-08-11 12:58 ` Dmitry Torokhov
2006-08-11 13:16 ` Richard Purdie
2006-08-11 13:34 ` Dmitry Torokhov
2006-08-11 13:42 ` Michael Hanselmann
2006-08-11 14:07 ` Dmitry Torokhov
2006-08-11 16:45 ` Richard Purdie
2006-08-11 17:20 ` Dmitry Torokhov
2006-08-29 20:54 ` Michael Hanselmann
2006-08-11 5:03 ` [patch 6/6] Move per-device data out of backlight_properties Dmitry Torokhov
2006-08-11 8:02 ` Richard Purdie
2006-08-11 12:27 ` Dmitry Torokhov
2006-08-11 12:55 ` Richard Purdie
2006-08-11 13:10 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060811050611.409915104.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®