From: Chuck Ebbert <76306.1226@compuserve.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for review] [145/145] i386: Disallow kprobes on NMI handlers
Date: Fri, 11 Aug 2006 19:13:34 -0400 [thread overview]
Message-ID: <200608111916_MC3-1-C7D7-ACA5@compuserve.com> (raw)
In-Reply-To: <200608110853.19740.ak@suse.de>
On Fri, 11 Aug 2006 08:53:19 +0200, Andi Kleen wrote:
> > > --- linux.orig/arch/i386/kernel/entry.S
> > > +++ linux/arch/i386/kernel/entry.S
> > > @@ -725,7 +725,7 @@ debug_stack_correct:
> > > * check whether we got an NMI on the debug path where the debug
> > > * fault happened on the sysenter path.
> > > */
> > > -ENTRY(nmi)
> > > +KPROBE_ENTRY(nmi)
> > > RING0_INT_FRAME
> > > pushl %eax
> > > CFI_ADJUST_CFA_OFFSET 4
> >
> > Needs .popsection at the end of the NMI code.
>
> This is fixed up in a later patch I think.
> i386: KPROBE_ENTRY ends up putting code into .fixup
That patch was earlier, not later. I applied the 060811 patchset from
firstfloor and you still need this:
--- 2.6.18-rc4-ff.orig/arch/i386/kernel/entry.S
+++ 2.6.18-rc4-ff/arch/i386/kernel/entry.S
@@ -801,6 +801,7 @@ nmi_16bit_stack:
.align 4
.long 1b,iret_exc
.previous
+.popsection
KPROBE_ENTRY(int3)
RING0_INT_FRAME
--
Chuck
next reply other threads:[~2006-08-11 23:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 23:13 Chuck Ebbert [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-11 6:37 Chuck Ebbert
2006-08-11 6:53 ` Andi Kleen
[not found] <20060810 935.775038000@suse.de>
2006-08-10 19:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608111916_MC3-1-C7D7-ACA5@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome