From: "YOSHIFUJI Hideaki / 吉藤英明" <yoshfuji@linux-ipv6.org>
To: gerrit@erg.abdn.ac.uk
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH 2.6.17] net/ipv6/udp.c: remove duplicate udp_get_port code
Date: Wed, 16 Aug 2006 17:51:44 +0900 (JST) [thread overview]
Message-ID: <20060816.175144.75075807.yoshfuji@linux-ipv6.org> (raw)
In-Reply-To: <200608160846.48174@strip-the-willow>
Hello.
In article <200608160846.48174@strip-the-willow> (at Wed, 16 Aug 2006 08:46:48 +0100), gerrit@erg.abdn.ac.uk says:
> UDPv4 and UDPv6 use an almost identical version of the get_port function,
> which is unnecessary since the (long) code differs in only one if-statement.
:
:
> +#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)
> + else if(sk->sk_family == PF_INET6 &&
> + ipv6_rcv_saddr_equal(sk, sk2) )
> + goto fail;
> + }
> +#endif
This is not good because you cannot link ipv6_rcv_saddr_equal()
if you are compiling IPv6 as module.
How about retaining udp_v{4,6}_get_port() and call
common udp_get_port() from both functions?
--yoshfuji
next prev parent reply other threads:[~2006-08-16 8:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-16 7:46 gerrit
2006-08-16 8:51 ` YOSHIFUJI Hideaki / 吉藤英明 [this message]
2006-08-16 12:46 ` gerrit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060816.175144.75075807.yoshfuji@linux-ipv6.org \
--to=yoshfuji@linux-ipv6.org \
--cc=davem@davemloft.net \
--cc=gerrit@erg.abdn.ac.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®