From: Nathan Scott <nathans@sgi.com>
To: Jesper Juhl <jesper.juhl@gmail.com>
Cc: linux-kernel@vger.kernel.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: remove pointless conditional testing 'nmp' vs NULL in fs/xfs/xfs_rtalloc.c::xfs_growfs_rt()
Date: Thu, 17 Aug 2006 16:31:10 +1000 [thread overview]
Message-ID: <20060817163109.A2792453@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <200608162244.19957.jesper.juhl@gmail.com>; from jesper.juhl@gmail.com on Wed, Aug 16, 2006 at 10:44:19PM +0200
On Wed, Aug 16, 2006 at 10:44:19PM +0200, Jesper Juhl wrote:
> On Monday 14 August 2006 09:25, Jesper Juhl wrote:
> > On 14/08/06, Nathan Scott <nathans@sgi.com> wrote:
> > > On Sun, Aug 13, 2006 at 12:16:50AM +0200, Jesper Juhl wrote:
> > >
> > > > This patch gets rid of the pointless check.
> > >
> > > Hmm, seems like code churn that makes the code slightly less
> > > obvious, but thats just me... I'd prefer a tested patch that
> > > implements the above suggestion, to be honest. :)
> > >
> > Ok, I'll see what I can come up with.
> >
>
> How this?
>
> Compile tested only since I'm at home and don't have any XFS filesystems to
> play with atm.
It looks good. I've tested it, and it works fine - I'll merge it
into my tree shortly. Thanks for following up on this.
cheers.
--
Nathan
prev parent reply other threads:[~2006-08-17 6:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-12 22:16 Jesper Juhl
2006-08-14 1:09 ` Nathan Scott
2006-08-14 7:25 ` Jesper Juhl
2006-08-16 20:44 ` Jesper Juhl
2006-08-17 6:31 ` Nathan Scott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060817163109.A2792453@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®