From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Andrew Morton <akpm@osdl.org>
Cc: Rolf Eike Beer <eike-kernel@sf-tec.de>,
linux-kernel@vger.kernel.org, "Chen,
Kenneth W" <kenneth.w.chen@intel.com>
Subject: Re: [PATCH][CHAR] Return better error codes if drivers/char/raw.c module init fails
Date: Fri, 18 Aug 2006 16:37:53 -0700 [thread overview]
Message-ID: <20060818163753.8f25d58d.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060818162743.f97ff431.akpm@osdl.org>
On Fri, 18 Aug 2006 16:27:43 -0700 Andrew Morton wrote:
> On Fri, 18 Aug 2006 09:18:30 +0200
> Rolf Eike Beer <eike-kernel@sf-tec.de> wrote:
>
> > Currently this module just returns 1 if anything on module init
> > fails. Store the error code of the different function calls and
> > return their error on problems.
> >
> > I'm not sure if this doesn't need even more cleanup, for example
> > kobj_put() is called only in one error case.
> >
>
> You seem to be using kmail in funky-confuse-sylpheed mode. Inlined
> patches in plain-text emails are preferred, please.
Something about the SLIM docum. patch did that too, although
it was not an attachment.
Sylpheed had trouble with the line endings....
Saving the patch to a file works well, but replying to it looks
like garbage.
---
~Randy
next prev parent reply other threads:[~2006-08-18 23:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 7:18 Rolf Eike Beer
2006-08-18 23:27 ` Andrew Morton
2006-08-18 23:37 ` Randy.Dunlap [this message]
2006-08-20 15:22 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060818163753.8f25d58d.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=eike-kernel@sf-tec.de \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®