Re: [PATCH] PCI: fix ICH6 quirks

[Jean Delvare <khali@linux-fr.org>]

> On Friday 18 August 2006 18.57, Jean Delvare wrote:
> > Hi Daniel,
> > 
> > > [PATCH] PCI: fix ICH6 quirks
> > > 
> > > - add the ICH6(R) LPC to the ICH6 ACPI quirks. currently only the ICH6-M is
> > >   handled. [ PCI_DEVICE_ID_INTEL_ICH6_1 is the ICH6-M LPC, ICH6_0 is the ICH6(R) ]
> > 
> > No objection.
> > 
> > > - remove the wrong quirk calling asus_hides_smbus_lpc() for ICH6. the register
> > >   modified in asus_hides_smbus_lpc() has a different meaning in ICH6.
> > 
> > My mistake :( Thanks for fixing it. Do you know if executing the old
> > quirk on the ICH6 can cause trouble? In other words, should we backport
> > this fix to 2.6.17.y?
> 
> the register it touches is part of the "root complex base address" register. so
> changing it means the ICH6 decodes a different address range that could conflict
> with something else...so yes, i think this is a 2.6.17.x candidate.

OK, this also means that we want your patch in 2.6.18. Greg, can you
pick it quickly?

Thanks,
-- 
Jean Delvare