Re: [PATCH] Return real errno from execve in ____call_usermodehelper

[Andrew Morton <akpm@osdl.org>]

On Sat, 19 Aug 2006 09:30:31 +0200
Björn Steinbrink <B.Steinbrink@gmx.de> wrote:

> If execve fails in ____call_usermodehelper we treat its return value as
> error code, but as execve is a syscall, we actually want -errno there.
> 
> Signed-off-by: Björn Steinbrink <B.Steinbrink@gmx.de>
> 
> --
> 
> diff --git a/kernel/kmod.c b/kernel/kmod.c
> index 1d32def..865abc0 100644
> --- a/kernel/kmod.c
> +++ b/kernel/kmod.c
> @@ -149,8 +149,10 @@ static int ____call_usermodehelper(void 
>  	set_cpus_allowed(current, CPU_MASK_ALL);
>  
>  	retval = -EPERM;
> -	if (current->fs->root)
> -		retval = execve(sub_info->path, sub_info->argv,sub_info->envp);
> +	if (current->fs->root) {
> +		execve(sub_info->path, sub_info->argv, sub_info->envp);
> +		retval = -errno;
> +	}
>  
>  	/* Exec failed? */
>  	sub_info->retval = retval;

ug.  I wish we could find some way of using do_execve() here.  Or hoist
sys_execve() out of the architectures.