From: Chuck Ebbert <76306.1226@compuserve.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: Jens Axboe <axboe@suse.de>, Andi Kleen <ak@suse.de>
Subject: [patch] block: fix queue bounce limit calculation
Date: Sat, 19 Aug 2006 06:11:34 -0400 [thread overview]
Message-ID: <200608190612_MC3-1-C895-98A8@compuserve.com> (raw)
Queue bounce should start after the max page, not on it.
Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>
---
Could this explain reported slowdown on x86_64 after limit was
changed in 2.6.16.7?
--- 2.6.17.9-64.orig/block/ll_rw_blk.c
+++ 2.6.17.9-64/block/ll_rw_blk.c
@@ -638,11 +638,11 @@ void blk_queue_bounce_limit(request_queu
/* Assume anything <= 4GB can be handled by IOMMU.
Actually some IOMMUs can handle everything, but I don't
know of a way to test this here. */
- if (bounce_pfn < (min_t(u64,0xffffffff,BLK_BOUNCE_HIGH) >> PAGE_SHIFT))
+ if (bounce_pfn <= (min_t(u64,0xffffffff,BLK_BOUNCE_HIGH) >> PAGE_SHIFT))
dma = 1;
q->bounce_pfn = max_low_pfn;
#else
- if (bounce_pfn < blk_max_low_pfn)
+ if (bounce_pfn <= blk_max_low_pfn)
dma = 1;
q->bounce_pfn = bounce_pfn;
#endif
--
Chuck
next reply other threads:[~2006-08-19 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 10:11 Chuck Ebbert [this message]
2006-08-19 20:58 ` Andi Kleen
2006-08-19 20:17 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608190612_MC3-1-C895-98A8@compuserve.com \
--to=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®