From: Francois Romieu <romieu@fr.zoreil.com>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: penberg@cs.Helsinki.FI, akpm@osdl.org, dvrabel@cantab.net,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
david@pleyades.net
Subject: Re: [PATCH 5/7] ip1000: Modify coding style of ipg_config_autoneg()
Date: Sat, 19 Aug 2006 12:17:17 +0200 [thread overview]
Message-ID: <20060819101717.GA26267@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1155844061.5006.13.camel@localhost.localdomain>
Jesse Huang <jesse@icplus.com.tw> :
> From: Jesse Huang <jesse@icplus.com.tw>
>
> This is only coding style modify for ipg_config_autoneg(). Thanks for the
> suggestion form Francois.
>
> Change Logs:
> Modify coding style of ipg_config_autoneg()
>
> ---
>
> drivers/net/ipg.c | 17 ++++++++++-------
> 1 files changed, 10 insertions(+), 7 deletions(-)
>
> 737498ca620437d8179e21be4d5220333066cbbd
> diff --git a/drivers/net/ipg.c b/drivers/net/ipg.c
> index f859107..be96f93 100644
> --- a/drivers/net/ipg.c
> +++ b/drivers/net/ipg.c
> @@ -491,11 +491,13 @@ static int ipg_config_autoneg(struct net
> int fullduplex;
> int txflowcontrol;
> int rxflowcontrol;
> + long MacCtrlValue;
Mixed case variables are not exactly welcome.
--
Ueimor
next prev parent reply other threads:[~2006-08-19 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-17 19:47 Jesse Huang
2006-08-19 10:17 ` Francois Romieu [this message]
2006-08-21 3:27 ` Jesse Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060819101717.GA26267@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=akpm@osdl.org \
--cc=david@pleyades.net \
--cc=dvrabel@cantab.net \
--cc=jesse@icplus.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.Helsinki.FI \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®