From: David Miller <davem@davemloft.net>
To: bunk@stusta.de
Cc: hch@infradead.org, James.Bottomley@SteelEye.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/scsi/wd33c93.c: cleanups
Date: Mon, 21 Aug 2006 12:31:42 -0700 (PDT) [thread overview]
Message-ID: <20060821.123142.08327833.davem@davemloft.net> (raw)
In-Reply-To: <20060821192215.GL11651@stusta.de>
From: Adrian Bunk <bunk@stusta.de>
Date: Mon, 21 Aug 2006 21:22:15 +0200
> On Mon, Aug 21, 2006 at 11:53:44AM +0100, Christoph Hellwig wrote:
> > On Mon, Aug 21, 2006 at 12:43:57PM +0200, Adrian Bunk wrote:
> > > This patch contains the following cleanups:
> > > - #include <linux/irq.h> for getting the prototypes of
> > > {dis,en}able_irq()
> >
> > nothing outside of arch code must ever include <linux/irq.h>
>
> Why?
> It sounds rather strange that non-arch code should use asm headers.
It's an unfortunate side effect of how the generic IRQ layer was done.
The linux/irq.h head should only be used on platforms that make use of
the generic IRQ layer.
asm/irq.h is what should be included by drivers and the like that want
the IRQ interfaces.
I'm not saying this is a good situation, it's just the way it is.
next prev parent reply other threads:[~2006-08-21 19:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 10:43 Adrian Bunk
2006-08-21 10:53 ` Christoph Hellwig
2006-08-21 19:22 ` Adrian Bunk
2006-08-21 19:24 ` Matthew Wilcox
2006-08-21 19:25 ` Russell King
2006-08-21 20:41 ` Adrian Bunk
2006-08-21 19:31 ` David Miller [this message]
2006-09-04 11:41 ` Adrian Bunk
2006-12-02 17:54 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821.123142.08327833.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@stusta.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®