From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Henne <henne@nachtwindheim.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, jgarzik <jgarzik@pobox.com>
Subject: Re: [PATCH] [DOCBOOK] fix segfault in docproc.c
Date: Mon, 21 Aug 2006 13:35:47 -0700 [thread overview]
Message-ID: <20060821133547.dbb9ee4c.rdunlap@xenotime.net> (raw)
In-Reply-To: <44E9FCB5.4050101@nachtwindheim.de>
On Mon, 21 Aug 2006 20:34:29 +0200 Henne wrote:
> From: Henrik Kretzschmar <henne@nachtwindheim.de>
>
> Adds a missing exit, if the file that should be parsed couldn't be opened.
> Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened.
> This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs.
>
> Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Thanks.
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Could you also update Documentation/DocBook/libata.tmpl to use
drivers/ata/ instead of drivers/scsi/ on the !I and !E lines?
> ---
>
> --- linux-2.6.18-rc4/scripts/basic/docproc.c 2006-06-18 03:49:35.000000000 +0200
> +++ linux/scripts/basic/docproc.c 2006-08-18 22:19:48.000000000 +0200
> @@ -177,6 +177,7 @@
> {
> fprintf(stderr, "docproc: ");
> perror(real_filename);
> + exit(1);
> }
> while(fgets(line, MAXLINESZ, fp)) {
> char *p;
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
---
~Randy
prev parent reply other threads:[~2006-08-21 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 18:34 Henne
2006-08-21 20:35 ` Randy.Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821133547.dbb9ee4c.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=akpm@osdl.org \
--cc=henne@nachtwindheim.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®