From: Francois Romieu <romieu@fr.zoreil.com>
To: Henne <henne@nachtwindheim.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Linker error on via-velocity driver
Date: Tue, 22 Aug 2006 00:07:35 +0200 [thread overview]
Message-ID: <20060821220735.GA12622@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <44EA14BF.5090102@nachtwindheim.de>
Henne <henne@nachtwindheim.de> :
[...]
> I found a bug in the via-velocity driver, but I cant find a maintainer
> for that, so I write to the lists.
> This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled.
> This is tested on i386 and x86_64.
> I'm not familiar with network stuff but I don't believe a device should
> depend on a protocol.
See the comment on top of velocity_get_ip() related to wol and arp.
How does it behave with the patch below:
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 3918990..30f21b6 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2173,6 +2173,7 @@ config VIA_VELOCITY
select CRC32
select CRC_CCITT
select MII
+ select INET if PM
help
If you have a VIA "Velocity" based network card say Y here.
--
Ueimor
prev parent reply other threads:[~2006-08-21 22:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-21 20:17 Henne
2006-08-21 22:07 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821220735.GA12622@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=henne@nachtwindheim.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®