mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: Jesse Huang <jesse@icplus.com.tw>
Cc: romieu@fr.zoreil.com, penberg@cs.Helsinki.FI, akpm@osdl.org,
	dvrabel@cantab.net, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, david@pleyades.net
Subject: Re: [PATCH] IP1000A: IC Plus update 2006-08-22
Date: Mon, 21 Aug 2006 23:14:55 -0700	[thread overview]
Message-ID: <20060821231455.1ce9474d.rdunlap@xenotime.net> (raw)
In-Reply-To: <1156268234.3622.1.camel@localhost.localdomain>

On Tue, 22 Aug 2006 13:37:14 -0400 Jesse Huang wrote:

> Dear All:
> I had regenerate this patch from:
> git://git.kernel.org/pub/scm/linux/kernel/git/penberg/netdev-ipg-2.6.git
> 
> And, submit those modifications as one patch.
> 
> Add: "Remove and add some whitespace"
> 
> From: Jesse Huang <jesse@icplus.com.tw>
> 
> Change Logs:
>    - update maintainer information
>    - remove some default phy params
>    - remove threshold config from ipg_io_config
>    - ip1000 ipg_config_autoneg rewrite
>    - modify coding style of ipg_config_autoneg
>    - Add IPG_AC_FIFO flag when Tx reset
>    - For compatible at PCI 66MHz issue
>    - Remove and add some whitespace
> 
> Signed-off-by: Jesse Huang <jesse@icplus.com.tw>


-	u8 phyctrl;
+	long mac_ctrl_value;

Should mac_ctrl_value be unsigned long or u32 instead of signed long?

We try to keep source lines limited to < 80 columns when feasible
so that they fit nicely into an xterm.  There are a few lines here
that are > 80 columns.

+		if((NextToFree != sp->CurrentTFD) && (NextToFree != CurrentTxTFDPtr))
+		{

Style:  need space after if; opening brace not on line by itself.

+		// Re-configure after DMA reset. 

Line ends with a space. :(

+	if (sp->ResetCurrentTFD != 0)
+	{

Opening brace not on line by itself -- put it on the previous line,
with a space between ) and {.

+		if (sp->LastTFDHoldAddr == sp->CurrentTFD) sp->LastTFDHoldCnt++;
+		else {sp->LastTFDHoldAddr = sp->CurrentTFD; sp->LastTFDHoldCnt=0; }

Split lines as:
		if (condition)
			action;
		else {
			action2;
		}


---
~Randy

  reply	other threads:[~2006-08-22  6:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-22 17:37 Jesse Huang
2006-08-22  6:14 ` Randy.Dunlap [this message]
2007-03-27  9:06   ` IP1000A: About IC Plus IP1000A Linux driver current status Jesse Huang
2007-03-27 17:53     ` Jeff Garzik
2007-03-27 22:24       ` Francois Romieu
2006-08-22 23:27 ` [PATCH] IP1000A: IC Plus update 2006-08-22 Francois Romieu
2006-08-23 11:38   ` Francois Romieu
2006-08-23 22:30     ` Francois Romieu
2006-08-24  1:31       ` Jesse Huang
2006-08-24 22:07         ` Francois Romieu
2006-08-27 22:08           ` Francois Romieu
2006-08-28  1:45             ` Jesse Huang
2006-08-30 22:43               ` Francois Romieu
2006-08-31  8:38                 ` Jesse Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060821231455.1ce9474d.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@osdl.org \
    --cc=david@pleyades.net \
    --cc=dvrabel@cantab.net \
    --cc=jesse@icplus.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=penberg@cs.Helsinki.FI \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®