From: David Miller <davem@davemloft.net>
To: ebrower@gmail.com
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: sym53c8xx PCI card broken in 2.6.18
Date: Tue, 22 Aug 2006 22:50:00 -0700 (PDT) [thread overview]
Message-ID: <20060822.225000.92584438.davem@davemloft.net> (raw)
In-Reply-To: <ec7cefb0608222235p155b7ab0ld8a23d2db1fbe56d@mail.gmail.com>
From: "Eric Brower" <ebrower@gmail.com>
Date: Tue, 22 Aug 2006 22:35:14 -0700
> Would you consider assigning -1 to lenp (if provided) in
> of_find_property() when no matching device is found?
I think checking for NULL should be the first thing a caller of these
interfaces should do. So from that perspective, I don't think putting
anything in *lenp makes sense. It's value is undefined.
In fact since we'll leave *lenp alone if the property doesn't exist,
you can initialize it to -1 if you want to simplify your checks.
next prev parent reply other threads:[~2006-08-23 5:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-22 14:46 David Johnson
2006-08-22 20:39 ` David Miller
2006-08-22 22:39 ` David Johnson
2006-08-23 3:59 ` Eric Brower
2006-08-23 4:01 ` David Miller
2006-08-23 5:35 ` Eric Brower
2006-08-23 5:50 ` David Miller [this message]
2006-08-23 21:01 ` Daniel Smolik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060822.225000.92584438.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebrower@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®