From: Andrew Morton <akpm@osdl.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Stephane Eranian <eranian@frankl.hpl.hp.com>,
linux-kernel@vger.kernel.org, eranian@hpl.hp.com
Subject: Re: [PATCH 9/18] 2.6.17.9 perfmon2 patch for review: kernel-level interface support
Date: Wed, 23 Aug 2006 15:54:47 -0700 [thread overview]
Message-ID: <20060823155447.a9eaf7fa.akpm@osdl.org> (raw)
In-Reply-To: <20060823152959.GD32725@infradead.org>
On Wed, 23 Aug 2006 16:29:59 +0100
Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Aug 23, 2006 at 01:06:00AM -0700, Stephane Eranian wrote:
> > This patch contains the kernel-level API support.
> >
> >
> > Some users have requested the ability to create a monitoring session
> > with perfmon2 from iside the kernel using a kernel thread. Perfmon2
> > leverages a lot of kernel mechanisms which are not easy to use for
> > inside the kernel: e.g. file descriptor, signals, system calls.
>
> Again, please drop this. There are no planned intree kernel users
> so far, and once we add them we can architect a proper API for them.
> Getting rid of this should also help to collapse the tons of useless
> abstractions layers in the current perfmon code.
>
Yes, I think we either need a stronger argument for including this code, or
we drop it.
It is especially worrisome that the exports which are added here are plain
old EXPORT_SYMBOL().
prev parent reply other threads:[~2006-08-23 23:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 8:06 Stephane Eranian
2006-08-23 15:29 ` Christoph Hellwig
2006-08-23 22:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060823155447.a9eaf7fa.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=eranian@frankl.hpl.hp.com \
--cc=eranian@hpl.hp.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®