From: Andrew Morton <akpm@osdl.org>
To: Stephane Eranian <eranian@frankl.hpl.hp.com>
Cc: linux-kernel@vger.kernel.org, eranian@hpl.hp.com
Subject: Re: [PATCH 10/18] 2.6.17.9 perfmon2 patch for review: PMU context switch support
Date: Wed, 23 Aug 2006 15:57:24 -0700 [thread overview]
Message-ID: <20060823155724.505fb979.akpm@osdl.org> (raw)
In-Reply-To: <200608230806.k7N86151000456@frankl.hpl.hp.com>
On Wed, 23 Aug 2006 01:06:01 -0700
Stephane Eranian <eranian@frankl.hpl.hp.com> wrote:
> +#define PFM_LAST_CPU(ctx, act) \
> + ((ctx)->last_cpu == smp_processor_id() && (ctx)->last_act == act)
Hiding this in a macro rather invites mistakes. Has all this code been
thoroughly tested with CONFIG_DEBUG_PREEMPT, to detect use of
smp_processor_id() in preemptible code?
prev parent reply other threads:[~2006-08-23 23:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 8:06 Stephane Eranian
2006-08-23 10:29 ` Andi Kleen
2006-08-25 11:56 ` Stephane Eranian
2006-08-25 12:20 ` Andi Kleen
2006-08-25 12:56 ` Stephane Eranian
2006-08-25 13:17 ` Andi Kleen
2006-08-23 22:57 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060823155724.505fb979.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=eranian@frankl.hpl.hp.com \
--cc=eranian@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®