From: Pavel Machek <pavel@ucw.cz>
To: Lennart Poettering <mzxreary@0pointer.de>
Cc: len.brown@intel.com, rubini@vision.unipv.it,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH] misc,acpi,backlight: MSI S270 Laptop support, third try
Date: Thu, 24 Aug 2006 07:52:26 +0200 [thread overview]
Message-ID: <20060824055226.GB1952@elf.ucw.cz> (raw)
In-Reply-To: <20060820225209.GA5453@curacao>
Hi!
> Please merge!
>
> I wonder who's the right one to ask for merging, since this driver
> sits in drivers/misc/. According to MAINTAINERS Alessandro Rubini
> maintains that directory. However it's somewhat based on the ACPI EC
> access stuff I posted earlier, hence the APCI tree might be another
> path to get this merged. Len, Alessandro, which one of you shall I
> bug to get this driver commited?
I guess Andrew is right person to get this in, but please follow
SubmittingPatches w.r.t. changelog.
> +/* $Id: msi-laptop.c 115 2006-08-20 20:02:54Z lennart $ */
Can you kill this? It only causes problems...
> +/*
> + * msi-laptop.c - MSI S270 laptop support. This laptop is sold under
> + * various brands, including "Cytron/TCM/Medion/Tchibo MD96100".
> + *
> + * This driver exports a few files in /sys/devices/platform/msi-laptop-pf/:
> + *
> + * lcd_level - Screen brightness: contains a single integer in the
> + * range 0..8. (rw)
> + *
> + * auto_brightness - Enable automatic brightness control: contains
> + * either 0 or 1. If set to 1 the hardware adjusts the screen
> + * brightness automatically when the power cord is
> + * plugged/unplugged. (rw)
> + *
> + * wlan - WLAN subsystem enabled: contains either 0 or 1. (ro)
> + *
> + * bluetooth - Bluetooth subsystem enabled: contains either 0 or 1
> + * Please note that this file is constantly 0 if no Bluetooth
> + * hardware is available. (ro)
User level documentation should go to Documentation/ somewhere. Not
sure if we have centralized place for /sys docs?
> +/*** Hardware access ***/
Can you remove extra ** s? They hurt my eyes.
> +static int set_lcd_level(int level) {
Indentation (you have this one detail consistently wrong).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2006-08-24 5:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-20 22:52 Lennart Poettering
2006-08-21 22:58 ` Andrew Morton
2006-08-24 5:52 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824055226.GB1952@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mzxreary@0pointer.de \
--cc=rubini@vision.unipv.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®