From: Masayuki Saito <m-saito@tnes.nec.co.jp>
To: Andrew Morton <akpm@osdl.org>
Cc: Nathan Scott <nathans@sgi.com>, David Chinner <dgc@sgi.com>,
xfs@oss.sgi.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add new spin_lock for i_flags of xfs_inode [try #2]
Date: Thu, 24 Aug 2006 19:05:19 +0900 [thread overview]
Message-ID: <20060824190519m-saito@mail.aom.tnes.nec.co.jp> (raw)
In-Reply-To: <20060823213817.16cdfe8a.akpm@osdl.org>
Thank you for your comment.
Andrew Morton <akpm@osdl.org> wrote:
>On Wed, 23 Aug 2006 20:12:51 +0900
>Masayuki Saito <m-saito@tnes.nec.co.jp> wrote:
>
>> It is the problem that i_flags of xfs_inode has no consistent
>> locking protection.
>>
>> For the reason, I define a new spin_lock(i_flags_lock) for i_flags
>> of xfs_inode. And I add this spin_lock for appropriate places.
>
>You could simply use inode.i_lock for this. i_lock is a general-purpose
>per-inode lock. Its mandate is "use it for whatever you like, but it must
>always be `innermost'"
>
I think that inode.i_lock isn't appropriate for this case.
Because there is the situation that no inode is attached to an xfs_inode.
Masayuki
prev parent reply other threads:[~2006-08-24 10:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-23 11:12 Masayuki Saito
2006-08-24 4:38 ` Andrew Morton
2006-08-24 5:42 ` Nathan Scott
2006-08-24 5:46 ` Nathan Scott
2006-08-24 10:05 ` Masayuki Saito [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060824190519m-saito@mail.aom.tnes.nec.co.jp \
--to=m-saito@tnes.nec.co.jp \
--cc=akpm@osdl.org \
--cc=dgc@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathans@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®