From: Toyo <toyoa@mvista.com>
To: Andi Kleen <ak@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale.
Date: Fri, 25 Aug 2006 10:14:46 -0700 (LDT) [thread overview]
Message-ID: <20060825.101446.01368169.toyoa@mvista.com> (raw)
In-Reply-To: <200608251855.57671.ak@suse.de>
From: Andi Kleen <ak@suse.de>
Subject: Re: [PATCH -mm] x86_64: Adjust the timing of initializing cyc2ns_scale.
Date: Fri, 25 Aug 2006 18:55:57 +0200
> On Friday 25 August 2006 18:45, Toyo Abe wrote:
> > The x86_64-mm-monotonic-clock.patch in 2.6.18-rc4-mm2 made a change to
> > the updating of monotonic_base. It now uses cycles_2_ns().
> >
> > I suggest that a set_cyc2ns_scale() should be done prior to the setup_irq().
> > Because cycles_2_ns() can be called from the timer ISR right after the irq0
> > is enabled.
>
> Added thanks. I folded it into the original patch.
>
> Did you actually see a failure or was this just from code review?
> -Andi
>
I didn't see any failure on it. It was just a speculation. But I think
it's better thing here.
Best Regards,
toyo
prev parent reply other threads:[~2006-08-25 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 16:45 Toyo Abe
2006-08-25 16:55 ` Andi Kleen
2006-08-25 17:14 ` Toyo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060825.101446.01368169.toyoa@mvista.com \
--to=toyoa@mvista.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®