mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: kmannth@gmail.com, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: another NUMA build error
Date: Fri, 25 Aug 2006 21:17:05 -0700	[thread overview]
Message-ID: <20060825211705.68e6a1dc.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060826105639.5680429d.kamezawa.hiroyu@jp.fujitsu.com>

> > 
> Hmm... is this the way to go ?
> Keith-san, please ack if Okay.

Works for me.  No build errors.  Thanks.
There are a couple of typos noted below that could be fixed up.

> --
> When we select NUMA with i386, the system is only X86_NUMAQ or using ACPI.
> 
> Signed-Off-By: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> 
> Index: linux-2.6.18-rc4/arch/i386/Kconfig
> ===================================================================
> --- linux-2.6.18-rc4.orig/arch/i386/Kconfig
> +++ linux-2.6.18-rc4/arch/i386/Kconfig
> @@ -142,6 +142,7 @@ config X86_SUMMIT
>  	  In particular, it is needed for the x440.
>  
>  	  If you don't have one of these computers, you should say N here.
> +	  If you want to build NUMA kernel, you have to select ACPI

		end with '.'

>  
>  config X86_BIGSMP
>  	bool "Support for other sub-arch SMP systems with more than 8 CPUs"
> @@ -169,6 +170,7 @@ config X86_GENERICARCH
>         help
>            This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
>  	  It is intended for a generic binary kernel.
> +	  if you want NUMA kernel, select ACPI. we need SRAT for build NUMA

	  If you want a NUMA kernel, enable ACPI. We need SRAT to build NUMA.

>  
>  config X86_ES7000
>  	bool "Support for Unisys ES7000 IA32 series"
> @@ -542,7 +544,7 @@ config X86_PAE
>  # Common NUMA Features
>  config NUMA
>  	bool "Numa Memory Allocation and Scheduler Support"
> -	depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SUMMIT && ACPI))
> +	depends on SMP && HIGHMEM64G && (X86_NUMAQ || (X86_SUMMIT || X86_GENERICARCH) && ACPI)
>  	default n if X86_PC
>  	default y if (X86_NUMAQ || X86_SUMMIT)


---
~Randy

      reply	other threads:[~2006-08-26  4:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-25  4:35 Randy.Dunlap
2006-08-25  5:43 ` KAMEZAWA Hiroyuki
2006-08-25 17:35   ` Randy.Dunlap
2006-08-25 18:28     ` KAMEZAWA Hiroyuki
2006-08-25 19:06       ` Randy.Dunlap
     [not found]     ` <a762e240608251544t2e15ec8dq5a8f95f02eecb0a4@mail.gmail.com>
2006-08-25 23:01       ` Randy.Dunlap
2006-08-26  1:56         ` KAMEZAWA Hiroyuki
2006-08-26  4:17           ` Randy.Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825211705.68e6a1dc.rdunlap@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=akpm@osdl.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=kmannth@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®