mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IPV6 : segmentation offload not set correctly on TCP children
Date: Sat, 26 Aug 2006 09:59:41 +1000	[thread overview]
Message-ID: <20060825235940.GA13086@gondor.apana.org.au> (raw)
In-Reply-To: <20060825154353.3ecaf508@localhost.localdomain>

On Fri, Aug 25, 2006 at 03:43:53PM -0700, Stephen Hemminger wrote:
> TCP over IPV6 would incorrectly inherit the GSO settings.
> This would cause kernel to send Tcp Segmentation Offload packets for
> IPV6 data to devices that can't handle it. It caused the sky2 driver
> to lock http://bugzilla.kernel.org/show_bug.cgi?id=7050
> and the e1000 would generate bogus packets. I can't blame the
> hardware for gagging if the upper layers feed it garbage.
> 
> This was a new bug in 2.6.18 introduced with GSO support.
> 
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>

Thanks for catching this Stephen!

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

      parent reply	other threads:[~2006-08-26  0:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-21 21:22 sky2 doesn't receive any packages after I ssh in via ipv6 and edit a file in vim (reproducable) Thomas Glanzmann
     [not found] ` <20060821150231.31a947d4@localhost.localdomain>
     [not found]   ` <20060821222634.GC21790@cip.informatik.uni-erlangen.de>
2006-08-25 22:43     ` [PATCH] IPV6 : segmentation offload not set correctly on TCP children Stephen Hemminger
2006-08-25 22:56       ` David Miller
2006-08-25 23:06       ` Thomas Glanzmann
2006-08-25 23:24         ` Stephen Hemminger
2006-08-25 23:29         ` Stephen Hemminger
2006-08-25 23:59       ` Herbert Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060825235940.GA13086@gondor.apana.org.au \
    --to=herbert@gondor.apana.org.au \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@osdl.org \
    --cc=sithglan@stud.uni-erlangen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®