From: Benjamin LaHaise <bcrl@kvack.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Make kmem_cache_destroy() return void
Date: Sat, 26 Aug 2006 11:31:47 -0400 [thread overview]
Message-ID: <20060826153147.GB18092@kvack.org> (raw)
In-Reply-To: <20060825212110.GB2246@martell.zuzino.mipt.ru>
On Sat, Aug 26, 2006 at 01:21:10AM +0400, Alexey Dobriyan wrote:
> un-, de-, -free, -destroy, -exit, etc functions should in general
> return void. Also,
> @@ -2411,7 +2410,6 @@ int kmem_cache_destroy(struct kmem_cache
> list_add(&cachep->next, &cache_chain);
> mutex_unlock(&cache_chain_mutex);
> unlock_cpu_hotplug();
> - return 1;
> }
>
> if (unlikely(cachep->flags & SLAB_DESTROY_BY_RCU))
Shouldn't this return, as otherwise there is a significant change in the
code path followed.
-ben
--
"Time is of no importance, Mr. President, only life is important."
Don't Email: <dont@kvack.org>.
next prev parent reply other threads:[~2006-08-26 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-25 21:21 Alexey Dobriyan
2006-08-26 15:31 ` Benjamin LaHaise [this message]
2006-08-26 15:48 ` [PATCH 2/2] " Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060826153147.GB18092@kvack.org \
--to=bcrl@kvack.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®