mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: akpm@osdl.org
Cc: miles.lane@gmail.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, jeremy@goop.org
Subject: Re: 2.6.18-rc4-mm[1,2,3] -- Network card not getting assigned an "eth" device name
Date: Sun, 27 Aug 2006 00:38:00 -0700 (PDT)	[thread overview]
Message-ID: <20060827.003800.95504796.davem@davemloft.net> (raw)
In-Reply-To: <20060827001943.c559d37d.akpm@osdl.org>

From: Andrew Morton <akpm@osdl.org>
Date: Sun, 27 Aug 2006 00:19:43 -0700

> Jeremy reported that a while back too.  I do not know what is causing it
> and as far as I know no net developers have yet looked into it.

A debugging patch like this one should help figure out the culprit.

If we don't see the gibberish netdevice name printed in the kernel
logs, then likely something is corrupting the netdevice structure or
the memory holding the name.

diff --git a/net/core/dev.c b/net/core/dev.c
index d4a1ec3..45f9b19 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -738,6 +738,11 @@ int dev_change_name(struct net_device *d
 
 	if (!dev_valid_name(newname))
 		return -EINVAL;
+#if 1
+	printk("[%s:%d]: Changing netdevice name from [%s] to [%s]\n",
+	       current->comm, current->pid,
+	       dev->name, newname);
+#endif
 
 	if (strchr(newname, '%')) {
 		err = dev_alloc_name(dev, newname);

  reply	other threads:[~2006-08-27  7:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <a44ae5cd0608270007gc6a919fx9e36562d8023635d@mail.gmail.com>
2006-08-27  7:19 ` Andrew Morton
2006-08-27  7:38   ` David Miller [this message]
2006-08-28 15:52     ` Miles Lane
2006-08-28 19:03       ` Andrew Morton
2006-08-28 20:27         ` David Miller
     [not found]           ` <a44ae5cd0608290143m3ad300eej5b325270c9d57b66@mail.gmail.com>
2006-08-29  9:26             ` David Miller
2006-08-27 16:30   ` Jeremy Fitzhardinge
2006-08-28 14:32     ` Benoit Boissinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060827.003800.95504796.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miles.lane@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®