Re: [PATCH 1/3] kthread: update s390 cmm driver to use kthread

[Heiko Carstens <heiko.carstens@de.ibm.com>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=unknown-8bit, Size: 1819 bytes --]

> AP instructions not installed. 
> BUG: warning at lib/kref.c:32/kref_get() 
> 000000000017719a 0000000000000002 0000000000000000 0000000000a03cf0  
>        0000000000a03c68 000000000037fc2c 000000000037fc2c 0000000000015dfa  
>        0000000000000000 0000000000000000 000000000043ac30 0000000000000000  
>        0000000000000000 000000000000000d 0000000000a03c50 0000000000a03cc8  
>        0000000000362488 0000000000015dfa 0000000000a03c50 0000000000a03ca0  
> Call Trace: 
> (Ý<0000000000015d44>¨ show_trace+0x9c/0xb8) 
>  Ý<0000000000015e18>¨ show_stack+0xb8/0xc8 
>  Ý<0000000000015e56>¨ dump_stack+0x2e/0x3c 
>  Ý<0000000000163f70>¨ kref_get+0x50/0x74 
>  Ý<0000000000162ec6>¨ kobject_get+0x32/0x44 
>  Ý<0000000000178fd6>¨ get_bus+0x36/0x60 
>  Ý<0000000000179a12>¨ bus_add_driver+0x3a/0x1f4 
>  Ý<000000000017ae30>¨ driver_register+0xb0/0xc0 
>  Ý<000000000021a1fe>¨ ap_driver_register+0x56/0x64 
>  Ý<00000000004c6ba6>¨ zcrypt_pcicc_init+0x36/0x44 
>  Ý<000000000001330c>¨ init+0x1bc/0x3a4 
>  Ý<00000000000184be>¨ kernel_thread_starter+0x6/0xc 
>  Ý<00000000000184b8>¨ kernel_thread_starter+0x0/0xc 

This should be fixed with -mm3. In addition you need this one on top of -mm3:

 arch/s390/kernel/time.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: linux-2.6.18-rc4-mm3/arch/s390/kernel/time.c
===================================================================
--- linux-2.6.18-rc4-mm3.orig/arch/s390/kernel/time.c	2006-08-28 10:32:45.000000000 +0200
+++ linux-2.6.18-rc4-mm3/arch/s390/kernel/time.c	2006-08-28 10:42:33.000000000 +0200
@@ -85,7 +85,8 @@
 {
 	__u64 now;
 
-        now = (get_clock() - jiffies_timer_cc) >> 12;
+	now = (get_clock() - jiffies_timer_cc) >> 12;
+	now -= (__u64) jiffies * USECS_PER_JIFFY;
 	return (unsigned long) now;
 }