From: Christoph Hellwig <hch@infradead.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [RFT] sched.h removal from module.h
Date: Tue, 29 Aug 2006 12:31:59 +0100 [thread overview]
Message-ID: <20060829113159.GB23975@infradead.org> (raw)
In-Reply-To: <44F39403.4060909@yahoo.com.au>
On Tue, Aug 29, 2006 at 11:10:27AM +1000, Nick Piggin wrote:
> >This is done by duplicating prototype of wake_up_process() which seems
> >to be the only thing module.h wants.
>
> This is really ugly, IMO. It makes the code less maintainable, so I don't
> think there is any point in doing it. In this case, we really do want to
> use scheduler functions, so the thing you do in that case is to include
> sched.h, not declare them yourself :(
>
> If you are particularly concerned about this, just move all those refcount
> inlines into kernel/module.c (they're too big anyway)... then you can drop
> the sched.h include from module.h for free ;)
Agreed. At least module_put should move out of line.
prev parent reply other threads:[~2006-08-29 11:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-27 15:32 Alexey Dobriyan
2006-08-29 1:10 ` Nick Piggin
2006-08-29 11:31 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829113159.GB23975@infradead.org \
--to=hch@infradead.org \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®