From: Christoph Hellwig <hch@infradead.org>
To: Nicholas Miell <nmiell@comcast.net>
Cc: Richard Knutsson <ricknu-0@student.ltu.se>,
Jan Engelhardt <jengelh@linux01.gwdg.de>,
Christoph Hellwig <hch@infradead.org>,
James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Conversion to generic boolean
Date: Tue, 29 Aug 2006 12:41:43 +0100 [thread overview]
Message-ID: <20060829114143.GB4076@infradead.org> (raw)
In-Reply-To: <1156792540.2367.2.camel@entropy>
On Mon, Aug 28, 2006 at 12:15:40PM -0700, Nicholas Miell wrote:
> > That is error-prone. Not "==FALSE" but what happens if x is (for some
> > reason) not 1 and then "if (x==TRUE)".
>
> If you're using _Bool, that isn't possible. (Except at the boundaries
> where you have to validate untrusted data -- and the compiler makes that
> more difficult, because it "knows" that a _Bool can only be 0 or 1 and
> therefore your check to see if it's not 0 or 1 can "safely" be
> eliminated.)
gcc lets you happily assign any integer value to bool/_Bool, so unless
you write sparse support for actually checking things there's not the
slightest advantage in value range checking.
next prev parent reply other threads:[~2006-08-29 11:42 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44EFBEFA.2010707@student.ltu.se>
2006-08-28 9:32 ` Christoph Hellwig
2006-08-28 9:45 ` Jesper Juhl
2006-08-29 11:39 ` Christoph Hellwig
2006-08-28 10:58 ` Jan Engelhardt
2006-08-28 11:11 ` Bernd Petrovitsch
2006-08-28 12:17 ` Richard Knutsson
2006-08-28 19:15 ` Nicholas Miell
2006-08-28 20:55 ` Richard Knutsson
2006-08-28 21:19 ` Nicholas Miell
2006-08-28 21:55 ` Richard Knutsson
2006-08-29 11:41 ` Christoph Hellwig [this message]
2006-08-29 12:17 ` Jan Engelhardt
2006-08-29 13:26 ` Peter Williams
2006-08-29 13:56 ` Jan Engelhardt
2006-08-29 12:48 ` Alan Cox
2006-08-29 0:18 ` Andrew Morton
2006-08-29 1:15 ` Nick Piggin
2006-08-29 5:58 ` Jan Engelhardt
2006-08-31 3:50 ` Dmitry Torokhov
2006-09-03 12:51 ` Pavel Machek
2006-08-29 7:29 ` Anton Altaparmakov
2006-08-29 11:46 ` Christoph Hellwig
2006-08-29 12:18 ` Anton Altaparmakov
2006-08-29 11:45 ` Christoph Hellwig
2006-08-29 14:10 ` Richard Knutsson
2006-08-29 15:47 ` Andrew Morton
2006-08-29 5:43 linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060829114143.GB4076@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nmiell@comcast.net \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®