mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Andrew Morton <akpm@osdl.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: prevent swsusp with PAE
Date: Thu, 31 Aug 2006 15:53:36 +0200	[thread overview]
Message-ID: <20060831135336.GL3923@elf.ucw.cz> (raw)

If HIGHMEM64G and swsusp are used at the same time, nasty random
crashes happen during resume. Cause is known; prevent that
combination.

I guess I'd like to see this one in 2.6.18...

Signed-off-by: Pavel Machek <pavel@suse.cz>

---
commit acb3b411ec93f827b25b8481d53670c5c9195d89
tree f52cd5518e34af16fe5ae28064717bcc95929f28
parent cd03e183c58e6e7073e054a7fe335cf50c61fe2f
author <pavel@amd.ucw.cz> Thu, 31 Aug 2006 15:52:34 +0200
committer <pavel@amd.ucw.cz> Thu, 31 Aug 2006 15:52:34 +0200

 include/asm-i386/suspend.h |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/include/asm-i386/suspend.h b/include/asm-i386/suspend.h
index 08be1e5..01cd812 100644
--- a/include/asm-i386/suspend.h
+++ b/include/asm-i386/suspend.h
@@ -16,6 +16,15 @@ arch_prepare_suspend(void)
 		printk(KERN_ERR "PSE is required for swsusp.\n");
 		return -EPERM;
 	}
+
+#ifdef CONFIG_X86_PAE
+	printk(KERN_ERR "swsusp is incompatible with PAE.\n");
+	/* This is actually instance of the same problem. We need
+	   identity mapping self-contained in swsusp_pg_dir, and PAE
+	   prevents that. Solution could be copied from x86_64. */
+	return -EPERM;
+#endif
+
 	return 0;
 }
 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

             reply	other threads:[~2006-08-31 13:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-31 13:53 Pavel Machek [this message]
2006-08-31 17:43 ` Andrew Morton
2006-08-31 22:35   ` Pavel Machek
2006-08-31 22:48     ` Randy.Dunlap
2006-08-31 22:48     ` Andrew Morton
2006-08-31 22:52       ` Pavel Machek
2006-08-31 23:05         ` Randy.Dunlap
2006-09-01  0:16           ` Andrew Morton
2006-09-01  0:44             ` Randy.Dunlap
2006-09-02 23:16           ` Pavel Machek
2006-09-01  7:22         ` Jan Engelhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060831135336.GL3923@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome