From: Nathan Scott <nathans@sgi.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: akpm@osdl.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Correcting error-prone boolean-statement
Date: Fri, 1 Sep 2006 11:16:01 +1000 [thread overview]
Message-ID: <20060901111601.R3186664@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <44F78A67.1060007@student.ltu.se>; from ricknu-0@student.ltu.se on Fri, Sep 01, 2006 at 03:18:31AM +0200
On Fri, Sep 01, 2006 at 03:18:31AM +0200, Richard Knutsson wrote:
> Nathan Scott wrote:
> >Are you using XFS on your systems? What is your strategy for getting this
> >runtime tested going to be? Or are you delegating that responsibility? :)
> >
> Sorry, can't say that I do. So pretty please... ;)
> Seriously, I can not find a state when this may fail (if not "if (var ==
> TRUE)" happend to be correct for 'var' != 0 != 1, but that is just a bug
> waiting to happend).
> But please correct me if I am wrong.
OK, I'll run with it in my own testing for awhile. I was also curious to
why you didn't remove the other few B_TRUE/B_FALSE occurences? (and the
typedef)?
cheers.
--
Nathan
next prev parent reply other threads:[~2006-09-01 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 23:52 Richard Knutsson
2006-09-01 0:07 ` Nathan Scott
2006-09-01 1:18 ` Richard Knutsson
2006-09-01 1:16 ` Nathan Scott [this message]
2006-09-01 1:38 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060901111601.R3186664@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®