From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751168AbWIBQbu (ORCPT ); Sat, 2 Sep 2006 12:31:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751172AbWIBQbu (ORCPT ); Sat, 2 Sep 2006 12:31:50 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:20140 "EHLO mx2.mail.elte.hu") by vger.kernel.org with ESMTP id S1751168AbWIBQbt (ORCPT ); Sat, 2 Sep 2006 12:31:49 -0400 Date: Sat, 2 Sep 2006 18:23:45 +0200 From: Ingo Molnar To: Jan Engelhardt Cc: Steven Whitehouse , linux-kernel@vger.kernel.org, Russell Cattelan , David Teigland , hch@infradead.org Subject: Re: [PATCH 03/16] GFS2: bmap and inode functions Message-ID: <20060902162345.GA23695@elte.hu> References: <1157031054.3384.788.camel@quoit.chygwyn.com> <20060902060939.GB16484@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i X-ELTE-SpamScore: -2.9 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.9 required=5.9 tests=ALL_TRUSTED,AWL,BAYES_50 autolearn=no SpamAssassin version=3.0.3 -3.3 ALL_TRUSTED Did not pass through any untrusted hosts 0.5 BAYES_50 BODY: Bayesian spam probability is 40 to 60% [score: 0.4481] -0.1 AWL AWL: From: address is in the auto white-list X-ELTE-VirusStatus: clean Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org * Jan Engelhardt wrote: > >> How about inverting the if() to: > >> > >> if(ip == NULL) > >> return; > >> if(test_bit(GLF_DIRTY, &gl->gl_flags)) > >> gfs_inode_attr_in(ip); > >> gfs2_meta_cache_flush(ip); > > > >btw., it should be "if (", not "if(". > > There is no such rule in CodingStyle. still it's part of the proper coding style :) Ingo -- VGER BF report: H 0