mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Josef Sipek <jsipek@fsl.cs.sunysb.edu>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	hch@infradead.org, akpm@osdl.org, viro@ftp.linux.org.uk
Subject: Re: [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem
Date: Sun, 3 Sep 2006 15:44:56 -0400	[thread overview]
Message-ID: <20060903194456.GA4977@filer.fsl.cs.sunysb.edu> (raw)
In-Reply-To: <Pine.LNX.4.61.0609031941210.12800@yvahk01.tjqt.qr>

On Sun, Sep 03, 2006 at 07:42:53PM +0200, Jan Engelhardt wrote:
> >> > This set of patches constitutes Unionfs version 2.0. We are presenting it to
> >> > be reviewed and considered for inclusion into the kernel.
> >> 
> >> Small nit: is it possible to order these patches so that the kernel
> >> builds at each intermediate point (so we can use git bisect).  The
> >> easiest way to achieve this would be to do the Kconfig and Makefile
> >> updates last.
> >
> >Ideally, when Unionfs is commited into git, the whole thing would be one
> >commit - what's the point of having half of a filesystem?
> 
> So that you can eliminate e.g. locking bugs by searching in less code.

I think you misunderstood my comment. What I meant to say was that there is
_no way_ you can compile a filesystem that has only dentry ops but not
superblock ops - this would happen if you tried to bisect and you landed
half way in the series of commits for the filesystem. For the _initial_
commit one cset makes sense. For subsequent fixes one commit per fix is the
only logical thing to do.

Josef "Jeff" Sipek.

-- 
Bad pun of the week: The formula 1 control computer suffered from a race
condition

-- 
VGER BF report: H 7.95683e-07

  reply	other threads:[~2006-09-03 19:45 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-01  1:35 Josef Sipek
2006-09-01  1:37 ` [PATCH 01/22][RFC] Unionfs: Documentation Josef Sipek
2006-09-01  7:42   ` Jan Engelhardt
2006-09-01  1:39 ` [PATCH 02/22][RFC] Unionfs: Kconfig and Makefile Josef Sipek
2006-09-01 12:44   ` Jan Engelhardt
2006-09-01 15:32     ` Randy.Dunlap
2006-09-01  1:40 ` [PATCH 03/22][RFC] Unionfs: Branch management functionality Josef Sipek
2006-09-04 11:20   ` Pekka Enberg
2006-09-01  1:41 ` [PATCH 04/22][RFC] Unionfs: Common file operations Josef Sipek
2006-09-01 12:50   ` Jan Engelhardt
2006-09-01 22:20   ` Trond Myklebust
2006-09-01 22:36     ` Shaya Potter
2006-09-01 22:57       ` Trond Myklebust
2006-09-03  1:03         ` Shaya Potter
2006-09-02  2:47     ` Josef Sipek
2006-09-03  4:10       ` Trond Myklebust
2006-09-01  1:42 ` [PATCH 05/22][RFC] Unionfs: Copyup Functionality Josef Sipek
2006-09-04  6:59   ` Jan Engelhardt
2006-09-04  9:25     ` Josef Sipek
2006-09-04 10:41       ` Jan Engelhardt
2006-09-16 22:13         ` Josef Sipek
2006-09-16 22:26           ` Jan Engelhardt
2006-09-17  1:28           ` Shaya Potter
2006-09-01  1:44 ` [PATCH 06/22][RFC] Unionfs: Dentry operations Josef Sipek
2006-09-04  7:04   ` Jan Engelhardt
2006-09-01  1:45 ` [PATCH 07/22][RFC] Unionfs: Directory file operations Josef Sipek
2006-09-04  7:07   ` Jan Engelhardt
2006-09-01  1:47 ` [PATCH 08/22][RFC] Unionfs: Directory manipulation helper functions Josef Sipek
2006-09-04  7:09   ` Jan Engelhardt
2006-09-04  7:23     ` Jeremy Fitzhardinge
2006-09-01  1:48 ` [PATCH 09/22][RFC] Unionfs: File operations Josef Sipek
2006-09-01  3:02   ` Ian Kent
2006-09-04  7:11   ` Jan Engelhardt
2006-09-01  1:49 ` [PATCH 10/22][RFC] Unionfs: Inode operations Josef Sipek
2006-09-04  7:18   ` Jan Engelhardt
2006-09-01  1:50 ` [PATCH 11/22][RFC] Unionfs: Lookup helper functions Josef Sipek
2006-09-04  7:24   ` Jan Engelhardt
2006-09-01  1:51 ` [PATCH 12/22][RFC] Unionfs: Main module functions Josef Sipek
2006-09-04  7:28   ` Jan Engelhardt
2006-09-01  1:53 ` [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem Stephen Rothwell
2006-09-01 17:23   ` Josef Sipek
2006-09-03 17:42     ` Jan Engelhardt
2006-09-03 19:44       ` Josef Sipek [this message]
2006-09-04 11:01         ` Pekka Enberg
2006-09-04 23:34           ` Josef Sipek
2006-09-01  1:53 ` [PATCH 13/22][RFC] Unionfs: Readdir state Josef Sipek
2006-09-04  7:30   ` Jan Engelhardt
2006-09-01  1:54 ` [PATCH 14/22][RFC] Unionfs: Rename Josef Sipek
2006-09-01  1:55 ` [PATCH 15/22][RFC] Unionfs: Privileged operations workqueue Josef Sipek
2006-09-04  7:37   ` Jan Engelhardt
2006-09-01  1:56 ` [PATCH 16/22][RFC] Unionfs: Handling of stale inodes Josef Sipek
2006-09-04  7:39   ` Jan Engelhardt
2006-09-01  1:58 ` [PATCH 17/22][RFC] Unionfs: Miscellaneous helper functions Josef Sipek
2006-09-01  1:58 ` [PATCH 18/22][RFC] Unionfs: Superblock operations Josef Sipek
2006-09-04  7:46   ` Jan Engelhardt
2006-09-04  8:24     ` Andreas Schwab
2006-09-01  1:59 ` [PATCH 19/22][RFC] Unionfs: Helper macros/inlines Josef Sipek
2006-09-04  7:49   ` Jan Engelhardt
2006-09-01  2:01 ` [PATCH 20/22][RFC] Unionfs: Internal include file Josef Sipek
2006-09-04  7:54   ` Jan Engelhardt
2006-09-01  2:01 ` [PATCH 21/22][RFC] Unionfs: Unlink Josef Sipek
2006-09-01  2:02 ` [PATCH 22/22][RFC] Unionfs: Include file Josef Sipek
2006-09-04  7:55   ` Jan Engelhardt
2006-09-03 11:05 ` [PATCH 00/22][RFC] Unionfs: Stackable Namespace Unification Filesystem Pavel Machek
2006-09-04 12:57   ` Jörn Engel
2006-09-05  4:46     ` Al Boldi
2006-09-05  7:01       ` Jörn Engel
2006-09-04 13:28   ` Shaya Potter
2006-09-04 20:33     ` Pavel Machek
2006-09-04 21:43       ` Shaya Potter
2006-09-04 23:31         ` Josef Sipek
2006-09-05  6:02         ` Jan Engelhardt
2006-09-05 13:02           ` Shaya Potter
2006-09-05  3:08     ` Trond Myklebust
2006-09-05  3:28       ` Shaya Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060903194456.GA4977@filer.fsl.cs.sunysb.edu \
    --to=jsipek@fsl.cs.sunysb.edu \
    --cc=akpm@osdl.org \
    --cc=hch@infradead.org \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®