From: Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.18-rc5 with GRE, iptables and Speedtouch ADSL, PPP over ATM
Date: Mon, 4 Sep 2006 12:44:14 +0400 [thread overview]
Message-ID: <20060904084414.GA19793@ms2.inr.ac.ru> (raw)
In-Reply-To: <20060903111507.GA12580@gondor.apana.org.au>
Hello!
> This path obviously breaks assumption 1) and therefore can lead to ABBA
> dead-locks.
Yes...
> I've looked at the history and there seems to be no reason for the lock
> to be held at all in dev_watchdog_up. The lock appeared in day one and
> even there it was unnecessary.
Seems, it serializes mod_timer and timer handler to keep timer
in predictable state. Maybe, this is not necessary. A priori, it is required.
Note that in dev_watchdog_down() queue_lock is released before
taking xmit_lock. Probably, this is the thing which was supposed
to be done in dev_watchdog_up() too.
Alexey
--
VGER BF report: U 0.46385
next prev parent reply other threads:[~2006-09-04 8:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-02 20:39 Krzysztof Halasa
2006-09-02 21:48 ` Francois Romieu
2006-09-02 22:59 ` Krzysztof Halasa
2006-09-03 11:15 ` Herbert Xu
2006-09-03 12:43 ` Krzysztof Halasa
2006-09-03 19:26 ` Larry Finger
2006-09-04 8:44 ` Alexey Kuznetsov [this message]
2006-09-04 8:48 ` Herbert Xu
2006-09-18 7:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904084414.GA19793@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome