From: Nathan Scott <nathans@sgi.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: akpm@osdl.org, xfs-masters@oss.sgi.com, xfs@oss.sgi.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc4-mm3 2/2] fs/xfs: Converting into generic boolean
Date: Mon, 4 Sep 2006 15:02:41 +1000 [thread overview]
Message-ID: <20060904150241.I3335706@wobbly.melbourne.sgi.com> (raw)
In-Reply-To: <44F833C9.1000208@student.ltu.se>; from ricknu-0@student.ltu.se on Fri, Sep 01, 2006 at 03:21:13PM +0200
On Fri, Sep 01, 2006 at 03:21:13PM +0200, Richard Knutsson wrote:
> From: Richard Knutsson <ricknu-0@student.ltu.se>
>
> Converting:
> 'B_FALSE' into 'false'
> 'B_TRUE' into 'true'
> 'boolean_t' into 'bool'
Hmm, so your bool is better than the next guys bool[ean[_t]]? :)
Seems like it'll be a few more days until the next cleanup patch
to remove _that_, so we shouldn't go that path. Since we do use
the current boolean_t somewhat inconsistently in XFS, I'd say we
should just toss the thing and use int.
I took the earlier patch and completed it, switching over to int
use in place of boolean_t in the few places it used - I'll merge
that at some point, when its had enough testing.
cheers.
--
Nathan
--
VGER BF report: U 0.496999
next prev parent reply other threads:[~2006-09-04 5:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 13:21 Richard Knutsson
2006-09-04 5:02 ` Nathan Scott [this message]
2006-09-04 10:24 ` Richard Knutsson
2006-09-05 3:05 ` Nathan Scott
2006-09-05 12:47 ` Richard Knutsson
2006-09-05 23:14 ` [xfs-masters] " Nathan Scott
2006-09-06 0:23 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904150241.I3335706@wobbly.melbourne.sgi.com \
--to=nathans@sgi.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
--cc=xfs-masters@oss.sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®