From: Francois Romieu <romieu@fr.zoreil.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Jan-Bernd Themann <ossthema@de.ibm.com>,
netdev <netdev@vger.kernel.org>, Jeff Garzik <jeff@garzik.org>,
Christoph Raisch <raisch@de.ibm.com>,
Jan-Bernd Themann <themann@de.ibm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-ppc <linuxppc-dev@ozlabs.org>,
Marcus Eder <meder@de.ibm.com>, Thomas Klein <tklein@de.ibm.com>
Subject: Re: [2.6.19 PATCH 1/7] ehea: interface to network stack
Date: Mon, 4 Sep 2006 23:49:45 +0200 [thread overview]
Message-ID: <20060904214945.GA30804@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <200609042311.21202.arnd@arndb.de>
Arnd Bergmann <arnd@arndb.de> :
[...]
> The driver should get merged as a single commit anyway, even
> if split diffs are posted for review. Even if it gets merged
> like this, bisect will work since the Kconfig option is added
> in the final patch.
I have seen/done worse but it's not exactly pretty.
[...]
> > > +?????int i;
> >
> > unsigned int ?
>
> does it matter? int as a counter is pretty standard.
ppc64 takes unsigned int as a little optimization. I do not know how
the target platform behaves here.
--
Ueimor
next prev parent reply other threads:[~2006-09-04 21:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 10:37 Jan-Bernd Themann
2006-09-04 20:16 ` Francois Romieu
2006-09-04 21:11 ` Arnd Bergmann
2006-09-04 21:49 ` Francois Romieu [this message]
2006-09-06 15:22 ` Jeff Garzik
2006-09-05 15:09 ` Thomas Klein
2006-09-05 18:58 ` Francois Romieu
2006-09-06 12:53 ` Jan-Bernd Themann
-- strict thread matches above, loose matches on Subject: below --
2006-09-06 13:30 Jan-Bernd Themann
2006-08-23 8:56 Jan-Bernd Themann
2006-08-22 12:51 Jan-Bernd Themann
2006-08-18 11:29 Jan-Bernd Themann
2006-08-18 13:47 ` Alexey Dobriyan
2006-08-18 13:56 ` Arjan van de Ven
2006-08-18 14:44 ` Alexey Dobriyan
2006-08-21 12:23 ` Jan-Bernd Themann
2006-08-21 13:18 ` Jörn Engel
2006-08-21 14:52 ` Thomas Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904214945.GA30804@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=arnd@arndb.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ossthema@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=themann@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome