From: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
To: Gene Heskett <gene.heskett@verizon.net>,
Linus Torvalds <torvalds@osdl.org>,
Jeremy Roberson <jroberson@gtcocalcomp.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.6.18-rc6
Date: Tue, 5 Sep 2006 00:31:54 +0200 [thread overview]
Message-ID: <20060904223153.GK13238@bayes.mathematik.tu-chemnitz.de> (raw)
In-Reply-To: <200609040705.53780.gene.heskett@verizon.net>
On Mon, Sep 04, 2006 at 07:05:53AM -0400, Gene Heskett wrote:
> On Sunday 03 September 2006 22:42, Linus Torvalds wrote:
> >Things are definitely calming down, and while I'm not ready to call it a
> >final 2.6.18 yet, this migt be the last -rc.
> >
> It has one new build warning, no idea if show stopper or not:
> ----------
> drivers/usb/input/hid-core.c:1447:1: warning: "USB_DEVICE_ID_GTCO_404"
> redefined
> drivers/usb/input/hid-core.c:1446:1: warning: this is the location of the
> previous definition
> ----------
> until after I boot to it...
>
> And that didn't seem to effect the mouse. Other usb stuff has not been
> exersized yet.
The offending patch is
hid-core.c: Adds all GTCO CalComp Digitizers and InterWrite School Products to blacklist
If one looks at this patch it seems to be just a typo.
The patch below fixes at least the warning.
--- vanilla-2.6.18-rc6/drivers/usb/input/hid-core.c 2006-09-04 04:19:48.000000000 +0200
+++ linux-2.6.18-rc6/drivers/usb/input/hid-core.c 2006-09-04 23:53:10.000000000 +0200
@@ -1444,7 +1444,7 @@
#define USB_DEVICE_ID_GTCO_402 0x0402
#define USB_DEVICE_ID_GTCO_403 0x0403
#define USB_DEVICE_ID_GTCO_404 0x0404
-#define USB_DEVICE_ID_GTCO_404 0x0405
+#define USB_DEVICE_ID_GTCO_405 0x0405
#define USB_DEVICE_ID_GTCO_500 0x0500
#define USB_DEVICE_ID_GTCO_501 0x0501
#define USB_DEVICE_ID_GTCO_502 0x0502
@@ -1657,7 +1657,7 @@
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_402, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_403, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
- { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_404, HID_QUIRK_IGNORE },
+ { USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_405, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_500, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_501, HID_QUIRK_IGNORE },
{ USB_VENDOR_ID_GTCO, USB_DEVICE_ID_GTCO_502, HID_QUIRK_IGNORE },
next prev parent reply other threads:[~2006-09-04 22:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 2:42 Linus Torvalds
2006-09-04 11:05 ` Gene Heskett
2006-09-04 22:31 ` Steffen Klassert [this message]
2006-09-05 0:17 ` Gene Heskett
2006-09-05 16:04 ` Alistair John Strachan
2006-09-05 20:02 ` Gene Heskett
2006-09-22 9:10 ` Konstantin Kletschke
2006-09-05 12:26 ` Olaf Hering
2006-09-05 12:45 ` maximilian attems
2006-09-05 18:56 ` Greg KH
2006-09-05 19:01 ` maximilian attems
2006-09-05 21:50 ` Greg KH
2006-09-05 21:01 ` James Bottomley
2006-09-05 22:20 ` Benjamin Herrenschmidt
2006-09-05 23:22 ` James Bottomley
2006-09-06 0:47 ` Benjamin Herrenschmidt
2006-09-06 12:09 ` Olaf Hering
2006-09-06 11:01 ` Olaf Hering
2006-09-06 14:04 ` James Bottomley
2006-09-07 9:15 ` Olaf Hering
2006-09-07 14:04 ` James Bottomley
2006-09-16 3:47 ` Doug Ledford
2006-09-16 8:44 ` Olaf Hering
2006-09-17 5:38 ` Olaf Hering
2006-09-17 14:05 ` James Bottomley
2006-09-17 18:17 ` Doug Ledford
2006-09-17 18:20 ` Doug Ledford
2006-09-12 15:04 Jody Belka
2006-09-12 22:33 ` Greg KH
2006-09-12 23:11 ` Jody Belka
2006-09-13 0:42 ` Jody Belka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060904223153.GK13238@bayes.mathematik.tu-chemnitz.de \
--to=klassert@mathematik.tu-chemnitz.de \
--cc=gene.heskett@verizon.net \
--cc=jroberson@gtcocalcomp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®