From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Stefan Seyfried <seife@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, Pavel Machek <pavel@ucw.cz>,
LKML <linux-kernel@vger.kernel.org>,
Laurent Riffard <laurent.riffard@free.fr>
Subject: Re: [PATCH -mm] PM: Remove sleeping from suspend_console
Date: Tue, 5 Sep 2006 13:08:37 +0200 [thread overview]
Message-ID: <200609051308.38401.rjw@sisk.pl> (raw)
In-Reply-To: <20060905062842.GA21738@suse.de>
On Tuesday, 5 September 2006 08:28, Stefan Seyfried wrote:
> On Mon, Sep 04, 2006 at 10:50:40PM +0200, Rafael J. Wysocki wrote:
> > Remove ssleep() from suspend_console().
> >
> > Stefan thinks it is unnecessary and will slow down the suspend too much.
>
> "unnecessary" is not exactly what i think, rather "unacceptable" :-)
Still that implies it's not necessary. ;-)
> We probably need to do something for some kinds of consoles to make sure all
> characters are sent, but sleeping unconditionally is not the right thing IMO.
Yup. This was added as a result of the Laurent Riffard's report that the sleep
was necessary, but it turned out to be due to the network card problem, so we
should get rid of the ssleep().
Greetings,
Rafael
--
You never change things by fighting the existing reality.
R. Buckminster Fuller
prev parent reply other threads:[~2006-09-05 11:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-04 20:50 Rafael J. Wysocki
2006-09-05 6:28 ` Stefan Seyfried
2006-09-05 11:08 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200609051308.38401.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=akpm@osdl.org \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=seife@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome