From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1422638AbWIGRWT@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1422638AbWIGRWT (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 7 Sep 2006 13:22:19 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422651AbWIGRWT
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 7 Sep 2006 13:22:19 -0400
Received: from smtp.osdl.org ([65.172.181.4]:60807 "EHLO smtp.osdl.org")
	by vger.kernel.org with ESMTP id S1422640AbWIGRWS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Sep 2006 13:22:18 -0400
Date: Thu, 7 Sep 2006 10:22:14 -0700
From: Andrew Morton <akpm@osdl.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/5] proc: Remove the hard coded inode numbers.
Message-Id: <20060907102214.4be99fff.akpm@osdl.org>
In-Reply-To: <m1fyf5x8ny.fsf_-_@ebiederm.dsl.xmission.com>
References: <m1odttx8uz.fsf@ebiederm.dsl.xmission.com>
	<m1k64hx8rx.fsf@ebiederm.dsl.xmission.com>
	<m1fyf5x8ny.fsf_-_@ebiederm.dsl.xmission.com>
X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.6; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 06 Sep 2006 10:27:13 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:

> +static int proc_fill_cache(struct file *filp, void *dirent, filldir_t filldir,
> +	char *name, int len,
> +	instantiate_t instantiate, struct task_struct *task, void *ptr)
> +{
> +	struct dentry *child, *dir = filp->f_dentry;
> +	struct inode *inode;
> +	struct qstr qname;
> +	ino_t ino = 0;
> +	unsigned type = DT_UNKNOWN;
> +
> +	qname.name = name;
> +	qname.len  = len;
> +	qname.hash = full_name_hash(name, len);
> +
> +	child = d_lookup(dir, &qname);
> +	if (!child) {
> +		struct dentry *new;
> +		new = d_alloc(dir, &qname);
> +		if (new) {
> +			child = instantiate(dir->d_inode, new, task, ptr);
> +			if (child)
> +				dput(new);
> +			else
> +				child = new;
> +		}
> +	}
> +	if (!child || IS_ERR(child) || !child->d_inode)
> +		goto end_instantiate;
> +	inode = child->d_inode;
> +	if (inode) {
> +		ino = inode->i_ino;
> +		type = inode->i_mode >> 12;
> +	}
> +	dput(child);
> +end_instantiate:
> +	if (!ino)
> +		ino = find_inode_number(dir, &qname);
> +	if (!ino)
> +		ino = 1;
> +	return filldir(dirent, name, len, filp->f_pos, ino, type);
> +}

The error handling in here looks rather absent.