From: Francois Romieu <romieu@fr.zoreil.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Hayim Shaul <hayim@iportent.com>, Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, edward_peng@dlink.com.tw,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.18-rc6 1/2] dllink driver: porting v1.19 to linux 2.6.18-rc6
Date: Thu, 7 Sep 2006 12:52:37 +0200 [thread overview]
Message-ID: <20060907105237.GA21270@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <1157620795.14882.16.camel@laptopd505.fenrus.org>
Arjan van de Ven <arjan@infradead.org> :
[...]
> > dev->trans_start = jiffies;
> > + tasklet_enable(&np->tx_tasklet);
> > + writew(DEFAULT_INTR, ioaddr + IntEnable);
> > + return;
>
> this looks like a PCI posting bug
Btw tx_tasklet is introduced in the relevant struct in patch #2.
Patch #1 will not compile.
--
Ueimor
next prev parent reply other threads:[~2006-09-07 10:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-07 9:09 Hayim Shaul
2006-09-07 9:19 ` Arjan van de Ven
2006-09-07 10:52 ` Francois Romieu [this message]
2006-09-10 11:10 ` Hayim Shaul
2006-09-21 13:29 ` Florian Weimer
2007-09-13 4:00 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060907105237.GA21270@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=arjan@infradead.org \
--cc=edward_peng@dlink.com.tw \
--cc=hayim@iportent.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®