From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
LKML <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: 2.6.18-rc5-mm1: strange /proc/interrupts contents on HPC nx6325
Date: Thu, 7 Sep 2006 15:51:05 +0200 [thread overview]
Message-ID: <20060907135105.GA3318@elte.hu> (raw)
In-Reply-To: <20060906201953.d96ee183.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> This is due to a gruesome hack (IMO) in the genirq code
> (handle_irq_name()) which magically "knows" about the various types of
> IRQ handler, but doesn't know about the MSI ones. It should be
> converted to a field in irq_desc, or a callback or something.
a field in irq_desc[] was frowned upon during initial genirq review, due
to size reasons, so i removed it and replaced it with the hack.
> I already had a whine about this then forgot about it, but it seems that
> code can't be changed by whining at it ;)
;)
i think we could add a 'register handler name' API (or extend
set_irq_handler() API), to pass in the name of handlers, and store it in
a small array (instead of embedding it in irq_desc)? handle_irq_name()
is not performance-critical.
Ingo
next prev parent reply other threads:[~2006-09-07 13:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-06 19:17 Rafael J. Wysocki
2006-09-07 3:19 ` Andrew Morton
2006-09-07 13:51 ` Ingo Molnar [this message]
2006-09-07 15:15 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060907135105.GA3318@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome