From: Andrew Morton <akpm@osdl.org>
To: Zach Brown <zach.brown@oracle.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 10/10] check pr_debug() arguments
Date: Fri, 8 Sep 2006 16:49:08 -0700 [thread overview]
Message-ID: <20060908164908.abb98076.akpm@osdl.org> (raw)
In-Reply-To: <20060908225529.9340.75338.sendpatchset@kaori.pdx.zabbo.net>
On Fri, 8 Sep 2006 15:55:29 -0700 (PDT)
Zach Brown <zach.brown@oracle.com> wrote:
> check pr_debug() arguments
>
> When DEBUG isn't defined pr_debug() is defined away as an empty macro. By
> throwing away the arguments we allow completely incorrect code to build.
>
> Instead let's make it an empty inline which checks arguments and mark it so gcc
> can check the format specification.
Desirable.
> This results in a seemingly insignificant code size increase. A x86-64
> allyesconfig:
>
> text data bss dec hex filename
> 25354768 7191098 4854720 37400586 23ab00a vmlinux.before
> 25354945 7191138 4854720 37400803 23ab0e3 vmlinux
Which would indicate that we might have expressions-with-side-effects
inside pr_debug() statements somewhere, which is risky. I wonder where?
It looks like the version of gcc which you used is correctly discarding the
pr_debug() format string. gcc hasn't always done that, and there's a risk
of bloatiness on older gccs. I checked gcc-3.3.2/x86 and it does the right
thing, so...
btw, what's up with aio.c using a combination of pr_debug() and dprintk(),
and a combination of `#ifdef DEBUG' and `#if DEBUG > 1'? Confusing.
It would be nice to have a single way of doing developer-debug in-tree. We
have 182(!) different definitions of dprintk(). Please nobody cc me on that
discussion though ;)
next prev parent reply other threads:[~2006-09-08 23:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-08 22:54 [PATCH 0/10] introduction: " Zach Brown
2006-09-08 22:54 ` [PATCH 1/10] futex: remove extra pr_debug format specifications Zach Brown
2006-09-08 22:54 ` [PATCH 2/10] aio: use size_t length modifier in pr_debug format arguments Zach Brown
2006-09-08 22:54 ` [PATCH 3/10] configfs: use size_t length modifier in pr_debug format argument Zach Brown
2006-09-09 0:15 ` Joel Becker
2006-09-08 22:54 ` [PATCH 4/10] sysfs: use size_t length modifier in pr_debug format arguments Zach Brown
2006-09-08 22:55 ` [PATCH 5/10] umem: repair nonexistant bh pr_debug reference Zach Brown
2006-09-08 22:55 ` [PATCH 6/10] tipar: repair nonexistant pr_debug argument use Zach Brown
2006-09-08 22:55 ` [PATCH 7/10] dell_rbu: fix pr_debug argument warnings Zach Brown
2006-09-08 22:55 ` [PATCH 8/10] ifb: replace missing comma to separate pr_debug arguments Zach Brown
2006-09-08 22:55 ` [PATCH 9/10] trident: use size_t length modifier in pr_debug format arguments Zach Brown
2006-09-08 22:55 ` [PATCH 10/10] check pr_debug() arguments Zach Brown
2006-09-08 23:49 ` Andrew Morton [this message]
2006-09-11 18:36 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060908164908.abb98076.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome