mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] i386-pda: Initialize the PDA early, before any C code runs.
Date: Tue, 12 Sep 2006 07:57:35 +0200	[thread overview]
Message-ID: <20060912055735.GB24298@elte.hu> (raw)
In-Reply-To: <4505F33E.3020009@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Jeremy Fitzhardinge wrote:
> >Not sure, but I think this replicates the behaviour of the original 
> >code (ie, INIT_THREAD_INFO initializes cpu to 0, so smp_processor_id 
> >will return 0).  Hm, Voyager will probably need a little patch to 
> >update the the PDA cpu_number properly in smp_setup_processor_id().
> 
> Something like this, perhaps:
> 
> Subject: set the boot CPU number in the boot_pda
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>

> +++ b/arch/i386/mach-voyager/voyager_smp.c	Mon Sep 11 16:34:09 2006 

> smp_setup_processor_id(void)
> {
> 	current_thread_info()->cpu = hard_smp_processor_id();
> -}
> +	write_pda(cpu_number, hard_smp_processor_id());
> +}

yeah. On all other x86 SMP platforms we use the logical APIC ID 0 for 
the boot CPU. (the physical ID might be different, but that doesnt 
matter)

NOTE: you'll also need to patch smp_voyager.c:find_smp_config(), where 
it sets current_thread_info()->cpu to boot_cpu_id.

	Ingo

  reply	other threads:[~2006-09-12  6:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-11 22:52 Jeremy Fitzhardinge
2006-09-11 23:03 ` Andrew Morton
2006-09-11 23:32   ` Jeremy Fitzhardinge
2006-09-11 23:37     ` Jeremy Fitzhardinge
2006-09-12  5:57       ` Ingo Molnar [this message]
2006-09-12  5:51 ` Ingo Molnar
2006-09-12  6:44 ` Andi Kleen
2006-09-12  8:32   ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060912055735.GB24298@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®