mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	dhowells@redhat.com
Subject: [PATCH 3/7] FRV: Optimise ffs() [try #3]
Date: Wed, 13 Sep 2006 19:35:27 +0100	[thread overview]
Message-ID: <20060913183527.22109.67075.stgit@warthog.cambridge.redhat.com> (raw)
In-Reply-To: <20060913183522.22109.10565.stgit@warthog.cambridge.redhat.com>

From: David Howells <dhowells@redhat.com>

Optimise ffs(x) by using fls(x & x - 1) which we optimise to use the SCAN
instruction.

Signed-Off-By: David Howells <dhowells@redhat.com>
---

 include/asm-frv/bitops.h |   33 +++++++++++++++++++++++++++++++--
 1 files changed, 31 insertions(+), 2 deletions(-)

diff --git a/include/asm-frv/bitops.h b/include/asm-frv/bitops.h
index 591eecc..1f70d47 100644
--- a/include/asm-frv/bitops.h
+++ b/include/asm-frv/bitops.h
@@ -157,8 +157,6 @@ (__builtin_constant_p(nr) ? \
  __constant_test_bit((nr),(addr)) : \
  __test_bit((nr),(addr)))
 
-#include <asm-generic/bitops/ffs.h>
-#include <asm-generic/bitops/__ffs.h>
 #include <asm-generic/bitops/find.h>
 
 /**
@@ -227,6 +225,37 @@ int fls64(u64 n)
 
 }
 
+/**
+ * ffs - find first bit set
+ * @x: the word to search
+ *
+ * - return 32..1 to indicate bit 31..0 most least significant bit set
+ * - return 0 to indicate no bits set
+ */
+static inline __attribute__((const))
+int ffs(int x)
+{
+	/* Note: (x & -x) gives us a mask that is the least significant
+	 * (rightmost) 1-bit of the value in x.
+	 */
+	return fls(x & -x);
+}
+
+/**
+ * __ffs - find first bit set
+ * @x: the word to search
+ *
+ * - return 31..0 to indicate bit 31..0 most least significant bit set
+ * - if no bits are set in x, the result is undefined
+ */
+static inline __attribute__((const))
+int __ffs(unsigned long x)
+{
+	int bit;
+	asm("scan %1,gr0,%0" : "=r"(bit) : "r"(x & -x));
+	return 31 - bit;
+}
+
 #include <asm-generic/bitops/sched.h>
 #include <asm-generic/bitops/hweight.h>
 

  parent reply	other threads:[~2006-09-13 18:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-09-13 18:35 [PATCH 1/7] FRV: Fix fls() to handle bit 31 being set correctly " David Howells
2006-09-13 18:35 ` [PATCH 2/7] FRV: Implement fls64() " David Howells
2006-09-13 18:35 ` David Howells [this message]
2006-09-13 18:35 ` [PATCH 4/7] Implement a general integer log2 facility in the kernel " David Howells
2006-09-14  1:19   ` Stephen Rothwell
2006-09-13 18:35 ` [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant " David Howells
2006-09-14  1:24   ` Stephen Rothwell
2006-09-14 11:52   ` David Howells
2006-09-15  1:35     ` Stephen Rothwell
2006-09-15 14:42     ` David Howells
2006-09-17 10:04       ` Stephen Rothwell
2006-09-19  7:30   ` Andrew Morton
2006-09-19  9:08   ` David Howells
2006-09-19 15:03     ` Andrew Morton
2006-09-19 15:08       ` Christoph Hellwig
2006-09-13 18:35 ` [PATCH 6/7] Alter roundup_pow_of_two() " David Howells
2006-09-13 18:35 ` [PATCH 7/7] Provide ilog2() fallbacks for powerpc " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060913183527.22109.67075.stgit@warthog.cambridge.redhat.com \
    --to=dhowells@redhat.com \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®